Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Issue 2329973003: Add net::BrotliSourceStream (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke, Randy Smith (Not in Mondays)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add net::BrotliSourceStream This CL adds a net::BrotliSourceStream to do brotli decoding. The new class is based on net::BrotliFilter but implements the new pull-based interface of net::FilterSourceStream. This is a part of the effort to convert net::Filter into a pull-based interface. See the linked bug for more details. BUG=474859 Committed: https://crrev.com/084a9290cededdcaf31e6ce30c8f58875fb34198 Cr-Commit-Position: refs/heads/master@{#420664}

Patch Set 1 #

Patch Set 2 : add missing deps #

Patch Set 3 : Sync-ed to 92104a0503b2862f54d60473b59dd1ae145eb22b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -97 lines) Patch
M net/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M net/DEPS View 1 1 chunk +4 lines, -0 lines 0 comments Download
A net/filter/brotli_source_stream.h View 1 chunk +21 lines, -0 lines 0 comments Download
A + net/filter/brotli_source_stream.cc View 1 2 5 chunks +63 lines, -90 lines 0 comments Download
A + net/filter/brotli_source_stream_disabled.cc View 1 chunk +4 lines, -7 lines 0 comments Download
A net/filter/brotli_source_stream_unittest.cc View 1 chunk +275 lines, -0 lines 0 comments Download
M net/net.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 36 (23 generated)
xunjieli
eustas@: PTAL. This is split from the original CL 1662763002. Thanks!
4 years, 3 months ago (2016-09-12 16:54:09 UTC) #4
eustas
lgtm
4 years, 3 months ago (2016-09-13 11:19:35 UTC) #7
xunjieli
ksakamoto@: Could you take a look at net/DEPS? Thanks! Randy and Matt: Let me know ...
4 years, 2 months ago (2016-09-21 19:10:28 UTC) #14
Kunihiko Sakamoto
net/DEPS lgtm
4 years, 2 months ago (2016-09-23 03:29:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329973003/40001
4 years, 2 months ago (2016-09-23 13:30:41 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/284931)
4 years, 2 months ago (2016-09-23 13:38:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329973003/40001
4 years, 2 months ago (2016-09-23 14:04:20 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/298590)
4 years, 2 months ago (2016-09-23 14:16:49 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329973003/40001
4 years, 2 months ago (2016-09-23 14:49:58 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/284991)
4 years, 2 months ago (2016-09-23 15:18:24 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329973003/40001
4 years, 2 months ago (2016-09-23 17:01:23 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-23 18:15:29 UTC) #34
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 18:17:19 UTC) #36
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/084a9290cededdcaf31e6ce30c8f58875fb34198
Cr-Commit-Position: refs/heads/master@{#420664}

Powered by Google App Engine
This is Rietveld 408576698