SkPDF: SkTypeface_FreeType ToUnicode table improvement.

SkPDF: SkTypeface_FreeType ToUnicode table improvement.

Currently the SkTypeface_FreeType::onGetAdvancedTypefaceMetrics
synthesized glyph to Unicode mapping returns the Unicode point
of the last character to map to the glyph. In practice it is
better to guess the first character to map to the glyph instead.

BUG=359065
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329953003

Committed: https://skia.googlesource.com/skia/+/5f1d0f61ea182829826d9d76cb85346d3e23305d

[hal.canary, 2016-09-12 15:54:36]

Description was changed from

==========
SkPDF: make freetype typeface ToUnicode table better

BUG=359065
==========

to

==========
SkPDF: make freetype typeface ToUnicode table better

BUG=359065
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329953003
==========

[hal.canary, 2016-09-12 15:54:44]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-09-12 15:54:58]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-09-12 15:54:58]

PTAL

[commit-bot: I haz the power, 2016-09-12 15:55:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 16:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 16:27:38]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-09-13 14:19:42]

Description was changed from

==========
SkPDF: make freetype typeface ToUnicode table better

BUG=359065
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329953003
==========

to

==========
SkPDF: SkTypeface_FreeType ToUnicode table improvement.

Currently the SkTypeface_FreeType::onGetAdvancedTypefaceMetrics
synthesized glyph to Unicode mapping returns the Unicode point
of the last character to map to the glyph. In practice it is
better to guess the first character to map to the glyph instead.

BUG=359065
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329953003
==========

[bungeman-skia, 2016-09-13 14:20:06]

lgtm with one nit about comment placement

https://codereview.chromium.org/2329953003/diff/1/src/ports/SkFontHost_FreeTy...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/2329953003/diff/1/src/ports/SkFontHost_FreeTy...
src/ports/SkFontHost_FreeType.cpp:452: // https://crbug.com/359065
This comment should go above the the 'if' block.

[hal.canary, 2016-09-13 14:36:17]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-09-13 14:36:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/2329953003/#ps20001
(title: "move comment")

[hal.canary, 2016-09-13 14:36:26]

https://codereview.chromium.org/2329953003/diff/1/src/ports/SkFontHost_FreeTy...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/2329953003/diff/1/src/ports/SkFontHost_FreeTy...
src/ports/SkFontHost_FreeType.cpp:452: // https://crbug.com/359065
On 2016/09/13 14:20:06, bungeman-skia wrote:
> This comment should go above the the 'if' block.

Done.

[commit-bot: I haz the power, 2016-09-13 14:36:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 15:08:40]

Description was changed from

==========
SkPDF: SkTypeface_FreeType ToUnicode table improvement.

Currently the SkTypeface_FreeType::onGetAdvancedTypefaceMetrics
synthesized glyph to Unicode mapping returns the Unicode point
of the last character to map to the glyph. In practice it is
better to guess the first character to map to the glyph instead.

BUG=359065
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329953003
==========

to

==========
SkPDF: SkTypeface_FreeType ToUnicode table improvement.

Currently the SkTypeface_FreeType::onGetAdvancedTypefaceMetrics
synthesized glyph to Unicode mapping returns the Unicode point
of the last character to map to the glyph. In practice it is
better to guess the first character to map to the glyph instead.

BUG=359065
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329953003

Committed:
https://skia.googlesource.com/skia/+/5f1d0f61ea182829826d9d76cb85346d3e23305d
==========

[commit-bot: I haz the power, 2016-09-13 15:08:41]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5f1d0f61ea182829826d9d76cb85346d3e23305d