Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2329943004: Mark infra steps as infra_step in GN recipe flavors. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Mark infra steps as infra_step in GN recipe flavors. NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329943004 Committed: https://skia.googlesource.com/skia/+/41313595f9f807c5dda8f2a1b6231a925672429c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M infra/bots/recipe_modules/flavor/gn_android_flavor.py View 2 chunks +5 lines, -1 line 0 comments Download
M infra/bots/recipe_modules/flavor/gn_flavor.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
mtklein_C
No simulation diffs... does that make sense?
4 years, 3 months ago (2016-09-12 21:00:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329943004/1
4 years, 3 months ago (2016-09-12 21:00:34 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-12 21:00:37 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 3 months ago (2016-09-13 03:00:30 UTC) #8
borenet
LGTM. Maybe the simulation test doesn't track which steps are infra_steps.
4 years, 3 months ago (2016-09-13 11:06:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329943004/1
4 years, 3 months ago (2016-09-13 11:07:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329943004/1
4 years, 3 months ago (2016-09-13 12:48:01 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 12:49:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/41313595f9f807c5dda8f2a1b6231a925672429c

Powered by Google App Engine
This is Rietveld 408576698