Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2329933003: [turbofan] Decouple OSR entry from {OsrPoll} bytecode. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Decouple OSR entry from {OsrPoll} bytecode. This makes sure OSR entry points can be added without having special {OsrPoll} instructions in the bytecode stream. Eventually we might end up merging back-branches and OSR polls together. Any loop header can be used as an OSR entry point. R=bmeurer@chromium.org BUG=v8:4764 Committed: https://crrev.com/069fcf4cbb6247151c7974ed8e38c1ff1c6e3db4 Cr-Commit-Position: refs/heads/master@{#39373}

Patch Set 1 #

Patch Set 2 : Add safety check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 5 chunks +22 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-12 13:22:03 UTC) #1
Michael Starzinger
Benedikt: PTAL. Ross: FYI.
4 years, 3 months ago (2016-09-12 16:30:52 UTC) #7
Benedikt Meurer
Nice. LGTM.
4 years, 3 months ago (2016-09-12 16:58:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329933003/20001
4 years, 3 months ago (2016-09-13 08:39:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-13 08:41:58 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 08:42:12 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/069fcf4cbb6247151c7974ed8e38c1ff1c6e3db4
Cr-Commit-Position: refs/heads/master@{#39373}

Powered by Google App Engine
This is Rietveld 408576698