Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 232993004: Reland "Allow cache reuse of some requests with Cache-Control headers" (Closed)

Created:
6 years, 8 months ago by Nate Chapin
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, gavinp+loader_chromium.org
Visibility:
Public.

Description

Reland "Allow cache reuse of some requests with Cache-Control headers" Traditionally, we have carefully handled Cache-Control headers that were set on a ResourceResponse, but have pretended Cache-Control doesn't exist on ResourceRequests. As of http://src.chromium.org/viewvc/blink?view=rev&rev=165603, we do the smarter naive thing, and never allow resources to be reused from MemoryCache if the ResourceRequest includes a Cache-Control header. This patch moves ResourceResponse's Cache-Control parsing to HTTPParsers and handles Cache-Control headers consistently, whether the header appears on a ResourceRequest or a ResourceResponse. BUG= This relands r171178. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171375

Patch Set 1 #

Patch Set 2 : +fix #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -213 lines) Patch
M Source/core/fetch/CachingCorrectnessTest.cpp View 3 chunks +30 lines, -0 lines 0 comments Download
M Source/core/fetch/Resource.h View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/fetch/Resource.cpp View 4 chunks +16 lines, -9 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/network/HTTPParsers.h View 2 chunks +18 lines, -0 lines 0 comments Download
M Source/platform/network/HTTPParsers.cpp View 2 chunks +143 lines, -0 lines 0 comments Download
A Source/platform/network/HTTPParsersTest.cpp View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 1 chunk +35 lines, -2 lines 0 comments Download
M Source/platform/network/ResourceResponse.h View 4 chunks +7 lines, -11 lines 0 comments Download
M Source/platform/network/ResourceResponse.cpp View 7 chunks +30 lines, -184 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Nate Chapin
Diff the two patches to see the fix for reland.
6 years, 8 months ago (2014-04-10 18:43:12 UTC) #1
abarth-chromium
The only delta is in the test...
6 years, 8 months ago (2014-04-10 22:18:57 UTC) #2
Nate Chapin
On 2014/04/10 22:18:57, abarth wrote: > The only delta is in the test... Correct. The ...
6 years, 8 months ago (2014-04-10 22:20:22 UTC) #3
Nate Chapin
On 2014/04/10 22:20:22, Nate Chapin wrote: > On 2014/04/10 22:18:57, abarth wrote: > > The ...
6 years, 8 months ago (2014-04-10 22:21:16 UTC) #4
abarth-chromium
LGTM
6 years, 8 months ago (2014-04-10 22:24:36 UTC) #5
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 8 months ago (2014-04-10 22:25:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/232993004/20001
6 years, 8 months ago (2014-04-10 22:25:50 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 23:07:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-10 23:07:20 UTC) #9
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 8 months ago (2014-04-11 16:31:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/232993004/20001
6 years, 8 months ago (2014-04-11 16:31:59 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 17:00:30 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 8 months ago (2014-04-11 17:00:30 UTC) #13
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 8 months ago (2014-04-11 20:31:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/232993004/40001
6 years, 8 months ago (2014-04-11 20:31:33 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 21:42:30 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-11 21:42:30 UTC) #17
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 8 months ago (2014-04-11 21:44:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/232993004/40001
6 years, 8 months ago (2014-04-11 21:44:12 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 22:19:44 UTC) #20
Message was sent while issue was closed.
Change committed as 171375

Powered by Google App Engine
This is Rietveld 408576698