Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2329923002: [turbofan] Properly respect --max_inlining_levels with Ignition. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly respect --max_inlining_levels with Ignition. The logic to test whether we already reached --max_inlining_levels when inlining into some optimized function only checked specifically for FrameStateType::kJavaScriptFunction, and thereby didn't properly account for FrameStateType::kInterpretedFunction, which is what we see when we come in via the bytecode pipeline. Committed: https://crrev.com/a5ca412e5acb8c2dffcc4ddeff74d3132064c29b Cr-Commit-Position: refs/heads/master@{#39328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/js-inlining-heuristic.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-12 07:15:59 UTC) #6
mvstanton
lgtm
4 years, 3 months ago (2016-09-12 07:17:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329923002/1
4 years, 3 months ago (2016-09-12 07:26:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 07:28:31 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 07:28:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5ca412e5acb8c2dffcc4ddeff74d3132064c29b
Cr-Commit-Position: refs/heads/master@{#39328}

Powered by Google App Engine
This is Rietveld 408576698