Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2329903002: Make net/sdch to use new URLRequest::Read and its modified delegate methods. (Closed)

Created:
4 years, 3 months ago by maksims (do not use this acc)
Modified:
4 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make net/sdch to use new URLRequest::Read and its modified delegate methods. This cl splits the big CL with changes to net/ folder and has changes only to net/sdch according to the changes to URLRequest API. What the big cl does: It modifies net/ clients that use URLRequest API as long as URLRequest::Read returns int net errors and URLRequest::Delegate and NetworkDelegate methods (for example, OnResponseStarted or OnCompleted) have int net_error in the arguments now. The reason behind splitting the CL into small one is that an android bot started to be unstable and unittests became flaky. It was not possible to locate the problem and the decision was to split the CL and upload small parts with a 6+ hours interval in order to make it possible to locate the problematic code. The big CL is located here - https://codereview.chromium.org/2265873002/ BUG=423484 Committed: https://crrev.com/d21e91636020a277b52bdbdde73d1e07ee0c57c0 Cr-Commit-Position: refs/heads/master@{#418489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M net/url_request/sdch_dictionary_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/sdch_dictionary_fetcher.cc View 5 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
maksims (do not use this acc)
please review.
4 years, 3 months ago (2016-09-12 06:46:13 UTC) #5
mmenke
LGTM
4 years, 3 months ago (2016-09-12 15:31:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329903002/1
4 years, 3 months ago (2016-09-14 03:46:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 04:49:54 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 04:51:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d21e91636020a277b52bdbdde73d1e07ee0c57c0
Cr-Commit-Position: refs/heads/master@{#418489}

Powered by Google App Engine
This is Rietveld 408576698