Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2329813002: Revert of Extract browser shared class initialization from ChromeApplication. (Closed)

Created:
4 years, 3 months ago by Ted C
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extract browser shared class initialization from ChromeApplication. (patchset #10 id:180001 of https://codereview.chromium.org/2297193003/ ) Reason for revert: Missed tests in chrome_public_apk. Need to do the same thing I did in SyncTestBase. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36140 Original issue's description: > Extract browser shared class initialization from ChromeApplication. > > There are still many other things that I would like to remove > from ChromeApplication. The foreground session tracking for > one could be moved to whatever delegate we settle on. > > initializeProcess() should also go away, but it seems tied to > the foreground session tracking. > > This focused on the two "more easily" moveable bits of the > deferred startup and class initialization. > > BUG=560466 ,b/31171101 > > Committed: https://crrev.com/5dc9845c8cde999555c74391eb9c61832b072157 > Cr-Commit-Position: refs/heads/master@{#417814} TBR=agrieve@chromium.org,yfriedman@chromium.org,wnwen@chromium.org,torne@chromium.org,nyquist@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560466 ,b/31171101 Committed: https://crrev.com/9c2f9252833b1b4e6ee0f280b43840882c052f08 Cr-Commit-Position: refs/heads/master@{#417837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -289 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 10 chunks +114 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java View 1 chunk +0 lines, -226 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapterService.java View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeInvalidationClientService.java View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ted C
Created Revert of Extract browser shared class initialization from ChromeApplication.
4 years, 3 months ago (2016-09-10 15:47:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329813002/1
4 years, 3 months ago (2016-09-10 15:48:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 15:49:02 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 15:51:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c2f9252833b1b4e6ee0f280b43840882c052f08
Cr-Commit-Position: refs/heads/master@{#417837}

Powered by Google App Engine
This is Rietveld 408576698