Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

Issue 2329803002: Drop FilterEffect::m_absolutePaintRect (Closed)
Patch Set: Add comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
index e3fe5ed731885efa863a60f29ad2101999f20922..f14c584aa31397567cd77ccd7e207ade1b8638d8 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
@@ -65,8 +65,6 @@ public:
return m_imageFilters[0] || m_imageFilters[1] || m_imageFilters[2] || m_imageFilters[3];
}
- IntRect absolutePaintRect() const { return m_absolutePaintRect; }
-
// Clipped primitive subregion in the coordinate space of the target.
FloatRect absoluteBounds() const;
@@ -106,8 +104,10 @@ public:
ColorSpace operatingColorSpace() const { return m_operatingColorSpace; }
virtual void setOperatingColorSpace(ColorSpace colorSpace) { m_operatingColorSpace = colorSpace; }
- virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect);
- virtual bool affectsTransparentPixels() { return false; }
+ // Compute the "paint rect" (which destination pixels will be affected) for
+ // the given rect. In the coordinate space of the target.
+ virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect) const;
+ virtual bool affectsTransparentPixels() const { return false; }
// Return false if the filter will only operate correctly on valid RGBA values, with
// alpha in [0,255] and each color component in [0, alpha].
@@ -130,13 +130,9 @@ protected:
SkImageFilter::CropRect getCropRect() const;
- void addAbsolutePaintRect(const FloatRect& absolutePaintRect);
-
private:
FilterEffectVector m_inputEffects;
- IntRect m_absolutePaintRect;
-
Member<Filter> m_filter;
// The following member variables are SVG specific and will move to LayoutSVGResourceFilterPrimitive.

Powered by Google App Engine
This is Rietveld 408576698