Issue 23297002: Revert "Trigger spell check/remove markers if spell checker gets enabled/disabled."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23297002: Revert "Trigger spell check/remove markers if spell checker gets enabled/disabled." (Closed)

Created:
7 years, 4 months ago by tony

Modified:
7 years, 4 months ago

Reviewers:
please use gerrit instead

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Trigger spell check/remove markers if spell checker gets enabled/disabled." There were multiple perf regressions. See crbug.com/274569 This reverts commit r156183. TBR=rouslan@chromium.org

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -307 lines)			Patch
D	LayoutTests/editing/spelling/spellcheck-disable-enable.html	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	LayoutTests/editing/spelling/spellcheck-disable-enable-expected.txt	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	LayoutTests/editing/spelling/spelling-huge-text.html	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	LayoutTests/editing/spelling/spelling-huge-text-expected.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	LayoutTests/editing/spelling/spelling-huge-text-sync.html	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	LayoutTests/editing/spelling/spelling-huge-text-sync-expected.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/editing/Editor.cpp	View	2 chunks	+13 lines, -27 lines	0 comments	Download
M	Source/core/editing/SpellCheckRequester.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	Source/core/editing/SpellCheckRequester.cpp	View	4 chunks	+8 lines, -21 lines	0 comments	Download
M	Source/web/EditorClientImpl.cpp	View	2 chunks	+2 lines, -21 lines	0 comments	Download