Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2329683002: Rename blobRegistry() functions and methods to getBlobRegistry(). (Closed)

Created:
4 years, 3 months ago by Łukasz Anforowicz
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, danakj, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename blobRegistry() functions and methods to getBlobRegistry(). The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |BlobRegistry| type and a |blobRegistry| function (differing only by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |BlobRegistry| being the name of both the type and the function (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 Committed: https://crrev.com/6babeb2daf414e7b650a9f38f6ebab7caba8c064 Cr-Commit-Position: refs/heads/master@{#417954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/mock_webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobRegistry.cpp View 8 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Łukasz Anforowicz
jochen@, could you please take a look?
4 years, 3 months ago (2016-09-09 23:41:58 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-12 09:58:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329683002/1
4 years, 3 months ago (2016-09-12 15:11:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 16:43:04 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 16:44:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6babeb2daf414e7b650a9f38f6ebab7caba8c064
Cr-Commit-Position: refs/heads/master@{#417954}

Powered by Google App Engine
This is Rietveld 408576698