chrome/browser/download/notification/download_item_notification.cc - Issue 2329633003: Implement progress bar spec (determinate and indeterminate).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_item_notification.cc

Issue 2329633003: Implement progress bar spec (determinate and indeterminate). (Closed)

Patch Set: attempt to unbreak mac and unit test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/notification/download_item_notification.cc

diff --git a/chrome/browser/download/notification/download_item_notification.cc b/chrome/browser/download/notification/download_item_notification.cc

index 095d3460c5445c701c74503a9850f67cb3d99ee5..dfaed46448c630dbcdad2e2281808645004a462b 100644

--- a/chrome/browser/download/notification/download_item_notification.cc

+++ b/chrome/browser/download/notification/download_item_notification.cc

@@ -387,6 +387,7 @@ void DownloadItemNotification::UpdateNotificationData(

// Negative progress value shows an indeterminate progress bar.

notification_->set_progress(-1);

}

notification_->set_type(message_center::NOTIFICATION_TYPE_PROGRESS);

break;

}