Split SVGImage-related cases into separate UseCounter histograms

Split SVGImage-related cases into separate UseCounter histograms

Doesn't change the legacy FeatureObserver histogram.

BUG=236262
Committed: https://crrev.com/19d7ef6e861608bf83d4b693f65f913ed920d5bf
Cr-Commit-Position: refs/heads/master@{#418155}

[Rick Byers, 2016-09-09 21:54:16]

rbyers@chromium.org changed reviewers:
+ pdr@chromium.org

[Rick Byers, 2016-09-09 21:54:16]

pdr, PTAL

It ended up being cleaner/simpler to just create the extra SVG-specific
histograms we talked about.  Let's give this a try and see what the data looks
like, then revisit later whether it's worth trying to combine them into a single
view.

[pdr., 2016-09-09 22:01:27]

On 2016/09/09 at 21:54:16, rbyers wrote:
> pdr, PTAL
> 
> It ended up being cleaner/simpler to just create the extra SVG-specific
histograms we talked about.  Let's give this a try and see what the data looks
like, then revisit later whether it's worth trying to combine them into a single
view.

Looks great!

If we land this, will we immediately start getting different data for the graphs
on chromestatus?

[Rick Byers, 2016-09-09 22:40:52]

On 2016/09/09 22:01:27, pdr. wrote:
> On 2016/09/09 at 21:54:16, rbyers wrote:
> > pdr, PTAL
> > 
> > It ended up being cleaner/simpler to just create the extra SVG-specific
> histograms we talked about.  Let's give this a try and see what the data looks
> like, then revisit later whether it's worth trying to combine them into a
single
> view.
> 
> Looks great!
> 
> If we land this, will we immediately start getting different data for the
graphs
> on chromestatus?

No.  Chromestatus uses the legacy histograms and will until we've convinced
ourselves there aren't more issues lurking, have archived a bit of history and
can explain how to roughly translate the old to the new (for people trying to
follow a longer term trend).  I figure the data is too important to the launch
process - need to give ourselves a transition period.  WDYT?

[pdr., 2016-09-09 23:26:12]

On 2016/09/09 at 22:40:52, rbyers wrote:
> On 2016/09/09 22:01:27, pdr. wrote:
> > On 2016/09/09 at 21:54:16, rbyers wrote:
> > > pdr, PTAL
> > > 
> > > It ended up being cleaner/simpler to just create the extra SVG-specific
> > histograms we talked about.  Let's give this a try and see what the data
looks
> > like, then revisit later whether it's worth trying to combine them into a
single
> > view.
> > 
> > Looks great!
> > 
> > If we land this, will we immediately start getting different data for the
graphs
> > on chromestatus?
> 
> No.  Chromestatus uses the legacy histograms and will until we've convinced
ourselves there aren't more issues lurking, have archived a bit of history and
can explain how to roughly translate the old to the new (for people trying to
follow a longer term trend).  I figure the data is too important to the launch
process - need to give ourselves a transition period.  WDYT?

SGTM LGTM!

[Rick Byers, 2016-09-12 14:28:12]

Description was changed from

==========
Split SVGImage-related cases into separate UseCounter histograms

Doesn't change the legacy FeatureObserver histogram.

BUG=236262
==========

to

==========
Split SVGImage-related cases into separate UseCounter histograms

Doesn't change the legacy FeatureObserver histogram.

BUG=236262
==========

[Rick Byers, 2016-09-12 14:28:12]

rbyers@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Rick Byers, 2016-09-12 14:28:49]

Thanks.  +rkaplow for metrics OWNERS (after we've agreed on the approach this
builds upon in https://codereview.chromium.org/2290733002/).

[rkaplow, 2016-09-12 15:20:57]

https://codereview.chromium.org/2329613002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2329613002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:66470: +    The bucket numbered '1' is
incremented each time a new SVG image is created.
this description is a bit confused since this uses a enum. WHy is this described
like this?

[Rick Byers, 2016-09-12 21:04:05]

https://codereview.chromium.org/2329613002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2329613002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:66470: +    The bucket numbered '1' is
incremented each time a new SVG image is created.
On 2016/09/12 15:20:57, rkaplow wrote:
> this description is a bit confused since this uses a enum. WHy is this
described
> like this?

Yeah I was just being lazy copying the existing text rather than improving it. 
Fixed, and fixed the source I copied from (which was itself copied from the
legacy description but I'll remove that soon so didn't bother improving that).

[rkaplow, 2016-09-12 21:06:28]

lgtm

[Rick Byers, 2016-09-13 00:59:12]

The CQ bit was checked by rbyers@chromium.org

[Rick Byers, 2016-09-13 00:59:13]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2329613002/#ps40001
(title: "Fix wording")

[commit-bot: I haz the power, 2016-09-13 00:59:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 03:08:11]

Description was changed from

==========
Split SVGImage-related cases into separate UseCounter histograms

Doesn't change the legacy FeatureObserver histogram.

BUG=236262
==========

to

==========
Split SVGImage-related cases into separate UseCounter histograms

Doesn't change the legacy FeatureObserver histogram.

BUG=236262
==========

[commit-bot: I haz the power, 2016-09-13 03:08:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-13 03:09:41]

Description was changed from

==========
Split SVGImage-related cases into separate UseCounter histograms

Doesn't change the legacy FeatureObserver histogram.

BUG=236262
==========

to

==========
Split SVGImage-related cases into separate UseCounter histograms

Doesn't change the legacy FeatureObserver histogram.

BUG=236262

Committed: https://crrev.com/19d7ef6e861608bf83d4b693f65f913ed920d5bf
Cr-Commit-Position: refs/heads/master@{#418155}
==========

[commit-bot: I haz the power, 2016-09-13 03:09:43]

Patchset 3 (id:??) landed as
https://crrev.com/19d7ef6e861608bf83d4b693f65f913ed920d5bf
Cr-Commit-Position: refs/heads/master@{#418155}