net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem - Issue 2329593002: Add optional context for certificate errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem

Issue 2329593002: Add optional context for certificate errors. (Closed)

Patch Set: Address Matt's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/intermediate-unknown-critical-extension.pem ('k') | net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem

diff --git a/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem b/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem

index d75f9ddd580b7aa14206a9341edf24e165df5459..019d304279429bb5c07906a12dded909dcb0ca82 100644

--- a/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem

+++ b/net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem

@@ -283,7 +283,10 @@ FAIL

RkFJTA==

-----END VERIFY_RESULT-----

-Target certificate looks like a CA but does not set all CA properties

+[Context] Processing Certificate

+ index: 1

+ [Error] Target certificate looks like a CA but does not set all CA properties

-----BEGIN ERRORS-----

-VGFyZ2V0IGNlcnRpZmljYXRlIGxvb2tzIGxpa2UgYSBDQSBidXQgZG9lcyBub3Qgc2V0IGFsbCBDQSBwcm9wZXJ0aWVz

+W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMQogICAgICBbRXJyb3JdIFRhcmdldCBjZXJ0aWZpY2F0ZSBsb29rcyBsaWtlIGEgQ0EgYnV0IGRvZXMgbm90IHNldCBhbGwgQ0EgcHJvcGVydGllcwo=

-----END ERRORS-----