net/data/verify_certificate_chain_unittest/violates-pathlen-1-constrained-root.pem - Issue 2329593002: Add optional context for certificate errors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/violates-pathlen-1-constrained-root.pem

Issue 2329593002: Add optional context for certificate errors. (Closed)

Patch Set: Address Matt's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 [Created by: generate-violates-pathlen-1-constrained-root.py]	1 [Created by: generate-violates-pathlen-1-constrained-root.py]

2	2

3 Certificate chain with 2 intermediates and one end entity certificate. The	3 Certificate chain with 2 intermediates and one end entity certificate. The

4 root certificate has a pathlen:1 restriction, and constraints are enforced	4 root certificate has a pathlen:1 restriction, and constraints are enforced

5 on this trust anchor making it an invalid chain.	5 on this trust anchor making it an invalid chain.

6	6

7 Certificate:	7 Certificate:

8 Data:	8 Data:

9 Version: 3 (0x2)	9 Version: 3 (0x2)

10 Serial Number: 1 (0x1)	10 Serial Number: 1 (0x1)

(...skipping 353 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
364 150302120000Z	364 150302120000Z

365 -----BEGIN TIME-----	365 -----BEGIN TIME-----

366 MTUwMzAyMTIwMDAwWg==	366 MTUwMzAyMTIwMDAwWg==

367 -----END TIME-----	367 -----END TIME-----

368	368

369 FAIL	369 FAIL

370 -----BEGIN VERIFY_RESULT-----	370 -----BEGIN VERIFY_RESULT-----

371 RkFJTA==	371 RkFJTA==

372 -----END VERIFY_RESULT-----	372 -----END VERIFY_RESULT-----

373	373

374 max_path_length reached	374 [Context] Processing Certificate

	375 index: 1

	376 [Error] max_path_length reached

	377

375 -----BEGIN ERRORS-----	378 -----BEGIN ERRORS-----

376 bWF4X3BhdGhfbGVuZ3RoIHJlYWNoZWQ=	379 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMQogICAgICBbRXJyb3JdIG1h eF9wYXRoX2xlbmd0aCByZWFjaGVkCg==

377 -----END ERRORS-----	380 -----END ERRORS-----

OLD	NEW