net/data/verify_certificate_chain_unittest/target-signed-with-md5.pem - Issue 2329593002: Add optional context for certificate errors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-signed-with-md5.pem

Issue 2329593002: Add optional context for certificate errors. (Closed)

Patch Set: Address Matt's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem ('k') | net/data/verify_certificate_chain_unittest/target-unknown-critical-extension.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-signed-with-md5.py]	1 [Created by: generate-target-signed-with-md5.py]

2	2

3 Certificate chain with an intermediate that uses MD5 to sign the target	3 Certificate chain with an intermediate that uses MD5 to sign the target

4 certificate. This is expected to fail because MD5 is too weak.	4 certificate. This is expected to fail because MD5 is too weak.

5	5

6 Certificate:	6 Certificate:

7 Data:	7 Data:

8 Version: 3 (0x2)	8 Version: 3 (0x2)

9 Serial Number: 1 (0x1)	9 Serial Number: 1 (0x1)

10 Signature Algorithm: md5WithRSAEncryption	10 Signature Algorithm: md5WithRSAEncryption

(...skipping 263 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
274 150302120000Z	274 150302120000Z

275 -----BEGIN TIME-----	275 -----BEGIN TIME-----

276 MTUwMzAyMTIwMDAwWg==	276 MTUwMzAyMTIwMDAwWg==

277 -----END TIME-----	277 -----END TIME-----

278	278

279 FAIL	279 FAIL

280 -----BEGIN VERIFY_RESULT-----	280 -----BEGIN VERIFY_RESULT-----

281 RkFJTA==	281 RkFJTA==

282 -----END VERIFY_RESULT-----	282 -----END VERIFY_RESULT-----

283	283

284 Invalid or unsupported signature algorithm	284 [Context] Processing Certificate

	285 index: 1

	286 [Error] Invalid or unsupported signature algorithm

	287 algorithm: 300D06092A864886F70D0101040500

	288

285 -----BEGIN ERRORS-----	289 -----BEGIN ERRORS-----

286 SW52YWxpZCBvciB1bnN1cHBvcnRlZCBzaWduYXR1cmUgYWxnb3JpdGht	290 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMQogICAgICBbRXJyb3JdIElu dmFsaWQgb3IgdW5zdXBwb3J0ZWQgc2lnbmF0dXJlIGFsZ29yaXRobQogICAgICAgIGFsZ29yaXRobTog MzAwRDA2MDkyQTg2NDg4NkY3MEQwMTAxMDQwNTAwCg==

287 -----END ERRORS-----	291 -----END ERRORS-----

OLD	NEW