net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage.pem - Issue 2329593002: Add optional context for certificate errors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage.pem

Issue 2329593002: Add optional context for certificate errors. (Closed)

Patch Set: Address Matt's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 [Created by: generate-intermediate-lacks-signing-key-usage.py]	1 [Created by: generate-intermediate-lacks-signing-key-usage.py]

2	2

3 Certificate chain with 1 intermediate and a trusted root. The intermediate	3 Certificate chain with 1 intermediate and a trusted root. The intermediate

4 contains a keyUsage extension, HOWEVER it does not contain the keyCertSign bit.	4 contains a keyUsage extension, HOWEVER it does not contain the keyCertSign bit.

5 Hence validation is expected to fail.	5 Hence validation is expected to fail.

6	6

7 Certificate:	7 Certificate:

8 Data:	8 Data:

9 Version: 3 (0x2)	9 Version: 3 (0x2)

10 Serial Number: 1 (0x1)	10 Serial Number: 1 (0x1)

(...skipping 264 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
275 150302120000Z	275 150302120000Z

276 -----BEGIN TIME-----	276 -----BEGIN TIME-----

277 MTUwMzAyMTIwMDAwWg==	277 MTUwMzAyMTIwMDAwWg==

278 -----END TIME-----	278 -----END TIME-----

279	279

280 FAIL	280 FAIL

281 -----BEGIN VERIFY_RESULT-----	281 -----BEGIN VERIFY_RESULT-----

282 RkFJTA==	282 RkFJTA==

283 -----END VERIFY_RESULT-----	283 -----END VERIFY_RESULT-----

284	284

285 keyCertSign bit is not set	285 [Context] Processing Certificate

	286 index: 0

	287 [Error] keyCertSign bit is not set

	288

286 -----BEGIN ERRORS-----	289 -----BEGIN ERRORS-----

287 a2V5Q2VydFNpZ24gYml0IGlzIG5vdCBzZXQ=	290 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMAogICAgICBbRXJyb3JdIGtl eUNlcnRTaWduIGJpdCBpcyBub3Qgc2V0Cg==

288 -----END ERRORS-----	291 -----END ERRORS-----

OLD	NEW