Remove toSVGStopElement(SVGElement*) because it can be covered by toSVGStopElement(Node*)

We don't need to keep two inline functions because toSVGStopElement(Node*) can support all casting.

BUG=N/A

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156444

[gyuyoung-inactive, 2013-08-19 08:32:52]

Hi Kent,

It looks I added unneeded inline function on r156274. If we use toSVGElement(),
we don't need to add  toSVGStopElement(Node* node.

[tkent, 2013-08-19 22:57:12]

https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):

https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
Source/core/rendering/svg/SVGRenderTreeAsText.cpp:628: SVGStopElement*
stopElement = toSVGStopElement(toSVGElement(stop.node()));
This looks worse.  I don't think we need to remove toSVGStopElement(Node*).

[gyuyoung-inactive, 2013-08-20 05:44:53]

https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):

https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
Source/core/rendering/svg/SVGRenderTreeAsText.cpp:628: SVGStopElement*
stopElement = toSVGStopElement(toSVGElement(stop.node()));
On 2013/08/19 22:57:12, tkent wrote:
> This looks worse.  I don't think we need to remove toSVGStopElement(Node*).

Do you have any reason ? But, I think this patch is trivial. So, if you think we
can keep toSVGStopElement(Node*), I'm willing to close this cl.

[tkent, 2013-08-20 06:09:33]

https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):

https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
Source/core/rendering/svg/SVGRenderTreeAsText.cpp:628: SVGStopElement*
stopElement = toSVGStopElement(toSVGElement(stop.node()));
On 2013/08/20 05:44:54, gyuyoung wrote:
> On 2013/08/19 22:57:12, tkent wrote:
> > This looks worse.  I don't think we need to remove toSVGStopElement(Node*).
> 
> Do you have any reason ? But, I think this patch is trivial. So, if you think
we
> can keep toSVGStopElement(Node*), I'm willing to close this cl.

When one wants to cast a Node to SVGStopElement, he needs to write
toSVGStopElement(toSVGElement(node)).  It's silly.

If you don't want to keep two toSVGStopElement() functions, you should remove
toSVGStopElement(SVGElement*) because toSVGStopElement(Node*) covers much.

[gyuyoung-inactive, 2013-08-20 06:35:14]

On 2013/08/20 06:09:33, tkent wrote:
>
https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
> File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):
> 
>
https://codereview.chromium.org/23295010/diff/1/Source/core/rendering/svg/SVG...
> Source/core/rendering/svg/SVGRenderTreeAsText.cpp:628: SVGStopElement*
> stopElement = toSVGStopElement(toSVGElement(stop.node()));
> On 2013/08/20 05:44:54, gyuyoung wrote:
> > On 2013/08/19 22:57:12, tkent wrote:
> > > This looks worse.  I don't think we need to remove
toSVGStopElement(Node*).
> > 
> > Do you have any reason ? But, I think this patch is trivial. So, if you
think
> we
> > can keep toSVGStopElement(Node*), I'm willing to close this cl.
> 
> When one wants to cast a Node to SVGStopElement, he needs to write
> toSVGStopElement(toSVGElement(node)).  It's silly.
> 
> If you don't want to keep two toSVGStopElement() functions, you should remove
> toSVGStopElement(SVGElement*) because toSVGStopElement(Node*) covers much.

I think it would be nice if we can reduce unneeded function. Ok, it looks I can
change SVGElement* with Node*. I will upload a new patch soon.

[gyuyoung-inactive, 2013-08-20 08:28:43]

On 2013/08/20 06:35:14, gyuyoung wrote:
 
> I think it would be nice if we can reduce unneeded function. Ok, it looks I
can
> change SVGElement* with Node*. I will upload a new patch soon.

New patch is uploaded !

[tkent, 2013-08-20 08:41:52]

https://codereview.chromium.org/23295010/diff/8001/Source/core/svg/SVGStopEle...
File Source/core/svg/SVGStopElement.h (right):

https://codereview.chromium.org/23295010/diff/8001/Source/core/svg/SVGStopEle...
Source/core/svg/SVGStopElement.h:55: ASSERT_WITH_SECURITY_IMPLICATION(!node ||
node->hasTagName(SVGNames::stopTag) || toSVGElement(node)->isGradientStop());
Either of hasTagName() or isGradientStop() should be enough.

[gyuyoung-inactive, 2013-08-20 10:43:48]

On 2013/08/20 08:41:52, tkent wrote:

> node->hasTagName(SVGNames::stopTag) || toSVGElement(node)->isGradientStop());
> Either of hasTagName() or isGradientStop() should be enough.

Fixed. Thanks.

[tkent, 2013-08-20 23:27:23]

lgtm

[commit-bot: I haz the power, 2013-08-20 23:27:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23295010/13001

[commit-bot: I haz the power, 2013-08-21 06:33:16]

Change committed as 156444