Added a new policy setting as well as corrisponding registry key for GCF

Added a new policy setting as well as corrisponding registry key to allow GCF users the option to disable the meta tag check. That is, the tag that websites can use to enable GCF. This way the white/black lists are fully respected by GCF.

BUG=225971
TEST=Set HKEY_CURRENT_USER\Software\Google\ChromeFrame\SkipGCFMetaDataCheck to true to disable GCF on sites enabled through the meta data tag (fully respects white/black lists).

Contributed by joe.knoll@workday.com
TBR=joaodasilva@chromium.org,robertshield@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218626

[grt (UTC plus 2), 2013-08-19 13:52:57]

lgtm. TBRing robertshield and joaodasilva since they gave their LGTM on issue
https://codereview.chromium.org/18770009/ (identical in all respects save the
author's email address).

[commit-bot: I haz the power, 2013-08-19 19:15:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joe.knoll@workday.com/23295005/1

[commit-bot: I haz the power, 2013-08-20 11:53:20]

Failed to apply patch for chrome/app/policy/policy_templates.json:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file chrome/app/policy/policy_templates.json
  Hunk #1 FAILED at 117.
  Hunk #2 succeeded at 2675 (offset 18 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/app/policy/policy_templates.json.rej

Patch:       chrome/app/policy/policy_templates.json
Index: chrome/app/policy/policy_templates.json
===================================================================
--- chrome/app/policy/policy_templates.json	(revision 218119)
+++ chrome/app/policy/policy_templates.json	(working copy)
@@ -117,7 +117,7 @@
 #   persistent IDs for all fields (but not for groups!) are needed. These are
 #   specified by the 'id' keys of each policy. NEVER CHANGE EXISTING IDs,
 #   because doing so would break the deployed wire format!
-#   For your editing convenience: highest ID currently used: 236
+#   For your editing convenience: highest ID currently used: 237
 #
 # Placeholders:
 #   The following placeholder strings are automatically substituted:
@@ -2657,6 +2657,25 @@
 
           If this policy is not set the default command line will be used.''',
         },
+        {
+          'name': 'SkipMetadataCheck',
+          'type': 'main',
+          'schema': { 'type': 'boolean' },
+          'supported_on': ['chrome_frame:30-'],
+          'features': {
+            'dynamic_refresh': False,
+          },
+          'example_value': False,
+          'id': 237,
+          'caption': '''Skip the meta tag check in <ph
name="PRODUCT_FRAME_NAME">$3<ex>Google Chrome Frame</ex></ph>''',
+          'desc': '''Normally pages with X-UA-Compatible set to chrome=1 will
be rendered in <ph name="PRODUCT_FRAME_NAME">$3<ex>Google Chrome Frame</ex></ph>
regardless of the 'ChromeFrameRendererSettings' policy.
+
+          If you enable this setting, pages will not be scanned for meta tags.
+
+          If you disable this setting, pages will be scanned for meta tags.
+
+          If this policy is not set, pages will be scanned for meta tags.'''
+        },
       ],
     },
     {

[grt (UTC plus 2), 2013-08-20 14:26:27]

https://codereview.chromium.org/23295005/diff/1/chrome/app/policy/policy_temp...
File chrome/app/policy/policy_templates.json (right):

https://codereview.chromium.org/23295005/diff/1/chrome/app/policy/policy_temp...
chrome/app/policy/policy_templates.json:120: #   For your editing convenience:
highest ID currently used: 237
it looks like someone else's change snuck in before yours. please re-sync and
adjust the ID. while you're at it, please also change the supported_on field to
'chrome_frame:31-' since this feature missed the M30 branch. thanks.

[JoeK, 2013-08-20 19:27:45]

On 2013/08/20 14:26:27, grt wrote:
>
https://codereview.chromium.org/23295005/diff/1/chrome/app/policy/policy_temp...
> File chrome/app/policy/policy_templates.json (right):
> 
>
https://codereview.chromium.org/23295005/diff/1/chrome/app/policy/policy_temp...
> chrome/app/policy/policy_templates.json:120: #   For your editing convenience:
> highest ID currently used: 237
> it looks like someone else's change snuck in before yours. please re-sync and
> adjust the ID. while you're at it, please also change the supported_on field
to
> 'chrome_frame:31-' since this feature missed the M30 branch. thanks.

Okay... uploaded.

Out of curiosity, how long does it typically take for accepted patches to make
it through the pipeline?

[commit-bot: I haz the power, 2013-08-20 19:31:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joe.knoll@workday.com/23295005/27001

[robertshield, 2013-08-20 19:32:10]

On 2013/08/20 19:27:45, JoeK wrote:
> On 2013/08/20 14:26:27, grt wrote:
> >
>
https://codereview.chromium.org/23295005/diff/1/chrome/app/policy/policy_temp...
> > File chrome/app/policy/policy_templates.json (right):
> > 
> >
>
https://codereview.chromium.org/23295005/diff/1/chrome/app/policy/policy_temp...
> > chrome/app/policy/policy_templates.json:120: #   For your editing
convenience:
> > highest ID currently used: 237
> > it looks like someone else's change snuck in before yours. please re-sync
and
> > adjust the ID. while you're at it, please also change the supported_on field
> to
> > 'chrome_frame:31-' since this feature missed the M30 branch. thanks.
> 
> Okay... uploaded.
> 
> Out of curiosity, how long does it typically take for accepted patches to make
> it through the pipeline?

It's fairly variable based on how many others commit at the same time and
infrastructure problems but I've seen it take up to 12 hours on a bad day. It's
not great and folk are working hard to improve it.

Took the liberty of hitting the CQ box asap to increase the chances of this
landing.

[commit-bot: I haz the power, 2013-08-21 03:47:13]

Change committed as 218626