Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 2329483003: Keep only InterfaceType(s) in resynthesized lists of interfaces and mixins. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Keep only InterfaceType(s) in resynthesized lists of interfaces and mixins. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7fd0aa00de8a90e2763a974d1d70068b786e993e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Replace not InterfaceType supertype with Object. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 3 chunks +8 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 3 months ago (2016-09-09 18:21:27 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2329483003/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2329483003/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode884 pkg/analyzer/lib/src/dart/element/element.dart:884: _supertype = enclosingUnit.resynthesizerContext Does this need to check ...
4 years, 3 months ago (2016-09-09 18:26:29 UTC) #2
Paul Berry
lgtm. Do we need to make a similar change for supertype?
4 years, 3 months ago (2016-09-09 18:27:54 UTC) #3
scheglov
https://codereview.chromium.org/2329483003/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2329483003/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode884 pkg/analyzer/lib/src/dart/element/element.dart:884: _supertype = enclosingUnit.resynthesizerContext On 2016/09/09 18:26:28, Brian Wilkerson wrote: ...
4 years, 3 months ago (2016-09-09 18:44:47 UTC) #4
scheglov
4 years, 3 months ago (2016-09-09 18:45:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7fd0aa00de8a90e2763a974d1d70068b786e993e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698