Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)
Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebSettingsImpl.cpp ('k') | third_party/WebKit/public/platform/WebData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
index 0872b56b1b83e24c821420b391678d59bcbd1799..bc274c0eba49af609742a9998acefe979170d07a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
@@ -2828,37 +2828,8 @@ def check_identifier_name_in_declaration(filename, line_number, line, file_state
is_function_arguments = is_function_arguments or character_after_identifier == '('
- # Remove "m_" and "s_" to allow them.
- modified_identifier = sub(r'(^|(?<=::))[ms]_', '', identifier)
- if not file_state.is_objective_c() and modified_identifier.find('_') >= 0:
- # Various exceptions to the rule: JavaScript op codes functions, const_iterator.
- if (not (filename.find('JavaScriptCore') >= 0 and modified_identifier.find('op_') >= 0)
- and not (filename.find('gtk') >= 0 and modified_identifier.startswith('webkit_') >= 0)
- and not (filename.find('StructTraits.h') >= 0)
- and not modified_identifier.startswith('tst_')
- and not modified_identifier.startswith('webkit_dom_object_')
- and not modified_identifier.startswith('webkit_soup')
- and not modified_identifier.startswith('NPN_')
- and not modified_identifier.startswith('NPP_')
- and not modified_identifier.startswith('NP_')
- and not modified_identifier.startswith('qt_')
- and not modified_identifier.startswith('_q_')
- and not modified_identifier.startswith('cairo_')
- and not modified_identifier.startswith('Ecore_')
- and not modified_identifier.startswith('Eina_')
- and not modified_identifier.startswith('Evas_')
- and not modified_identifier.startswith('Ewk_')
- and not modified_identifier.startswith('cti_')
- and not modified_identifier.find('::qt_') >= 0
- and not modified_identifier.find('::_q_') >= 0
- and not modified_identifier == 'const_iterator'
- and not modified_identifier == 'vm_throw'
- and not modified_identifier == 'DFG_OPERATION'):
- error(line_number, 'readability/naming/underscores', 4, identifier +
- " is incorrectly named. Don't use underscores in your identifier names.")
-
# Check for variables named 'l', these are too easy to confuse with '1' in some fonts
- if modified_identifier == 'l':
+ if identifier == 'l':
error(line_number, 'readability/naming', 4, identifier +
" is incorrectly named. Don't use the single letter 'l' as an identifier name.")
« no previous file with comments | « third_party/WebKit/Source/web/WebSettingsImpl.cpp ('k') | third_party/WebKit/public/platform/WebData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698