Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)
Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index ba7ddeacca8b1b3851a0cd3172bd5d211539f6ae..8d3a4e11295ef65512008cae98691243daa606a3 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -1031,20 +1031,24 @@ void ThreadState::postSweep() {
timeForSweepHistogram.count(m_accumulatedSweepingTime);
#define COUNT_COLLECTION_RATE_HISTOGRAM_BY_GC_REASON(GCReason) \
- case BlinkGC::GCReason: { \
+ case BlinkGC::k##GCReason: { \
DEFINE_STATIC_LOCAL(CustomCountHistogram, histogram, \
("BlinkGC.CollectionRate_" #GCReason, 1, 100, 20)); \
histogram.count(static_cast<int>(100 * collectionRate)); \
break; \
}
- switch (m_heap->lastGCReason()) {
+ switch (heap_->lastGCReason()) {
+ /* DO NOT SUBMIT - Conflict resolution helper:
+ * important to use IdleGC, rather than kIdleGC below - stringification */
COUNT_COLLECTION_RATE_HISTOGRAM_BY_GC_REASON(IdleGC)
COUNT_COLLECTION_RATE_HISTOGRAM_BY_GC_REASON(PreciseGC)
COUNT_COLLECTION_RATE_HISTOGRAM_BY_GC_REASON(ConservativeGC)
COUNT_COLLECTION_RATE_HISTOGRAM_BY_GC_REASON(ForcedGC)
COUNT_COLLECTION_RATE_HISTOGRAM_BY_GC_REASON(MemoryPressureGC)
COUNT_COLLECTION_RATE_HISTOGRAM_BY_GC_REASON(PageNavigationGC)
+ /* DO NOT SUBMIT - Conflict resolution helper:
+ * important to use IdleGC, rather than kIdleGC above - stringification */
default:
break;
}
@@ -1356,19 +1360,21 @@ void ThreadState::takeSnapshot(SnapshotType type) {
{ \
numberOfHeapsReported++; \
switch (type) { \
- case SnapshotType::HeapSnapshot: \
- m_arenas[BlinkGC::ArenaType##ArenaIndex]->takeSnapshot( \
- heapsDumpName + "/" #ArenaType, info); \
+ case SnapshotType::kHeapSnapshot: \
+ arenas_[BlinkGC::k##ArenaType##ArenaIndex]->TakeSnapshot( \
+ heaps_dump_name + "/" #ArenaType, info); \
break; \
- case SnapshotType::FreelistSnapshot: \
- m_arenas[BlinkGC::ArenaType##ArenaIndex]->takeFreelistSnapshot( \
- heapsDumpName + "/" #ArenaType); \
+ case SnapshotType::kFreelistSnapshot: \
+ arenas_[BlinkGC::k##ArenaType##ArenaIndex]->TakeFreelistSnapshot( \
+ heaps_dump_name + "/" #ArenaType); \
break; \
default: \
ASSERT_NOT_REACHED(); \
} \
}
+ /* DO NOT SUBMIT - Conflict resolution helper:
+ * Important to use NormalPage instead of kNormalPage1 below */
SNAPSHOT_HEAP(NormalPage1);
SNAPSHOT_HEAP(NormalPage2);
SNAPSHOT_HEAP(NormalPage3);
@@ -1381,6 +1387,8 @@ void ThreadState::takeSnapshot(SnapshotType type) {
SNAPSHOT_HEAP(InlineVector);
SNAPSHOT_HEAP(HashTable);
SNAPSHOT_HEAP(LargeObject);
+ /* DO NOT SUBMIT - Conflict resolution helper:
+ * Important to use LargeObject instead of kLargeObject above */
FOR_EACH_TYPED_ARENA(SNAPSHOT_HEAP);
ASSERT(numberOfHeapsReported == BlinkGC::NumberOfArenas);
« no previous file with comments | « third_party/WebKit/Source/platform/heap/HeapTest.cpp ('k') | third_party/WebKit/Source/platform/heap/asm/SaveRegisters_arm.S » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698