third_party/WebKit/Source/build/scripts/make_style_builder.py - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_style_builder.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/build/scripts/make_style_builder.py

diff --git a/third_party/WebKit/Source/build/scripts/make_style_builder.py b/third_party/WebKit/Source/build/scripts/make_style_builder.py

index 70cc8e98e3e85dfcbd1bbd1c3cb0fc2e3b8a2682..f73c570bc698a6644d7aac6fb9526ceaa9e834fd 100755

--- a/third_party/WebKit/Source/build/scripts/make_style_builder.py

+++ b/third_party/WebKit/Source/build/scripts/make_style_builder.py

@@ -57,16 +57,16 @@ class StyleBuilderWriter(css_properties.CSSProperties):

name = property['name_for_methods']

simple_type_name = str(property['type_name']).split('::')[-1]

set_if_none(property, 'type_name', 'E' + name)

- set_if_none(property, 'getter', lower_first(name) if simple_type_name != name else 'get' + name)

- set_if_none(property, 'setter', 'set' + name)

+ set_if_none(property, 'getter', name if simple_type_name != name else 'Get' + name)

+ set_if_none(property, 'setter', 'Set' + name)

set_if_none(property, 'inherited', False)

- set_if_none(property, 'initial', 'initial' + name)

+ set_if_none(property, 'initial', 'Initial' + name)

if property['custom_all']:

property['custom_initial'] = True

property['custom_inherit'] = True

property['custom_value'] = True

if property['inherited']:

- property['is_inherited_setter'] = 'set' + name + 'IsInherited'

+ property['is_inherited_setter'] = 'Set' + name + 'IsInherited'

property['should_declare_functions'] = not property['use_handlers_for'] and not property['longhands'] \

and not property['direction_aware'] and not property['builder_skip'] \

and property['is_property']