Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)
Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_utilities.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
index dec531fd2a4f8ccfc0605058fffc0d95d09ce3e1..17cb07c104d93f60f3e1d4c5a867dd615fdddba5 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
@@ -200,8 +200,8 @@ CALL_WITH_ARGUMENTS = {
'ScriptState': 'scriptState',
'ExecutionContext': 'executionContext',
'ScriptArguments': 'scriptArguments',
- 'CurrentWindow': 'currentDOMWindow(info.GetIsolate())',
- 'EnteredWindow': 'enteredDOMWindow(info.GetIsolate())',
+ 'CurrentWindow': 'CurrentDOMWindow(info.GetIsolate())',
+ 'EnteredWindow': 'EnteredDOMWindow(info.GetIsolate())',
'Document': 'document',
'ThisValue': 'ScriptValue(scriptState, info.Holder())',
}
@@ -243,16 +243,16 @@ def deprecate_as(member):
# [Exposed]
EXPOSED_EXECUTION_CONTEXT_METHOD = {
- 'AnimationWorklet': 'isAnimationWorkletGlobalScope',
- 'AudioWorklet': 'isAudioWorkletGlobalScope',
- 'CompositorWorker': 'isCompositorWorkerGlobalScope',
- 'DedicatedWorker': 'isDedicatedWorkerGlobalScope',
- 'PaintWorklet': 'isPaintWorkletGlobalScope',
- 'ServiceWorker': 'isServiceWorkerGlobalScope',
- 'SharedWorker': 'isSharedWorkerGlobalScope',
- 'Window': 'isDocument',
- 'Worker': 'isWorkerGlobalScope',
- 'Worklet': 'isWorkletGlobalScope',
+ 'AnimationWorklet': 'IsAnimationWorkletGlobalScope',
+ 'AudioWorklet': 'IsAudioWorkletGlobalScope',
+ 'CompositorWorker': 'IsCompositorWorkerGlobalScope',
+ 'DedicatedWorker': 'IsDedicatedWorkerGlobalScope',
+ 'PaintWorklet': 'IsPaintWorkletGlobalScope',
+ 'ServiceWorker': 'IsServiceWorkerGlobalScope',
+ 'SharedWorker': 'IsSharedWorkerGlobalScope',
+ 'Window': 'IsDocument',
+ 'Worker': 'IsWorkerGlobalScope',
+ 'Worklet': 'IsWorkletGlobalScope',
}
@@ -344,7 +344,7 @@ def secure_context(member, interface):
"""Returns C++ code that checks whether an interface/method/attribute/etc. is exposed
to the current context."""
if 'SecureContext' in member.extended_attributes or 'SecureContext' in interface.extended_attributes:
- return "executionContext->isSecureContext()"
+ return "executionContext->IsSecureContext()"
return None
@@ -478,9 +478,9 @@ def on_instance(interface, member):
if member.is_static:
return False
- # TODO(yukishiino): Remove a hack for toString once we support
- # Symbol.toStringTag.
- if (interface.name == 'Window' and member.name == 'toString'):
+ # TODO(yukishiino): Remove a hack for ToString once we support
+ # Symbol.ToStringTag.
+ if interface.name == 'Window' and member.name == 'ToString':
return False
# TODO(yukishiino): Implement "interface object" and its [[Call]] method
@@ -624,7 +624,7 @@ def named_property_getter(interface):
if ('getter' in method.specials and
len(method.arguments) == 1 and
str(method.arguments[0].idl_type) == 'DOMString'))
- getter.name = getter.name or 'anonymousNamedGetter'
+ getter.name = getter.name or 'AnonymousNamedGetter'
return getter
except StopIteration:
return None

Powered by Google App Engine
This is Rietveld 408576698