third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

index 584c7ba969c4ec10eebbf18ee390037b8d8e4e80..79a00b54802aad9ee71f91a13bc4b7759766ecf0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

@@ -46,6 +46,8 @@ template <typename ElementType>

void getScriptableObjectProperty(

const AtomicString& name,

const v8::PropertyCallbackInfo<v8::Value>& info) {

+ /* DO NOT SUBMIT - merge conflict marker.

+ * Please spell |toImpl| below (not |ToImpl|). */

HTMLPlugInElement* impl = ElementType::toImpl(info.Holder());

RefPtr<SharedPersistent<v8::Object>> wrapper = impl->pluginWrapper();

if (!wrapper)

@@ -75,6 +77,8 @@ void setScriptableObjectProperty(