third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: Rebasing the fixes... Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

index 96821797f92ac43b169c10593300f7e54fecf6fb..90954562015a26e10d064979ed005a5df0bc9f82 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

@@ -21,7 +21,7 @@

#include <memory>

#define NOTIFICATION_PER_TYPE_HISTOGRAM_COUNTS(metric, type_name, value, max) \

- case NotificationImageLoader::Type::type_name: { \

+ case NotificationImageLoader::Type::k##type_name: { \

DEFINE_THREAD_SAFE_STATIC_LOCAL( \

CustomCountHistogram, metric##type_name##Histogram, \

new CustomCountHistogram("Notifications." #metric "." #type_name, \

@@ -31,10 +31,14 @@

}

#define NOTIFICATION_HISTOGRAM_COUNTS(metric, type, value, max) \

+ /* DO NOT SUBMIT - conflict resolution helper:

+ * Important to have Image instead of kImage below. */

switch (type) { \

NOTIFICATION_PER_TYPE_HISTOGRAM_COUNTS(metric, Image, value, max) \

NOTIFICATION_PER_TYPE_HISTOGRAM_COUNTS(metric, Icon, value, max) \

NOTIFICATION_PER_TYPE_HISTOGRAM_COUNTS(metric, Badge, value, max) \

+ /* DO NOT SUBMIT - conflict resolution helper:

+ * Important to have ActionIcon instead of kActionIcon below. */

NOTIFICATION_PER_TYPE_HISTOGRAM_COUNTS(metric, ActionIcon, value, max) \

}