third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: Rebasing the fixes... Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/create-html-entity-table ('k') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

index 44febb608a321e3345abc4b186e78b1469c079c5..fe5c31627103db31411dbd07863b6634f5c94d3b 100755

--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

@@ -71,7 +71,7 @@ $methods

template_impl = string.Template("""

${return_type} ${name}(${params})

{

- InstrumentingAgents* agents = instrumentingAgentsFor(${first_param_name});

+ InstrumentingAgents* agents = InstrumentingAgentsFor(${first_param_name});

if (!agents)

${default_return}${impl_lines}${maybe_default_return}

}""")

@@ -128,8 +128,8 @@ void InstrumentingAgents::add${class_name}(${class_name}* agent)

void InstrumentingAgents::remove${class_name}(${class_name}* agent)

{

- ${member_name}.remove(agent);

- ${has_member_name} = !${member_name}.isEmpty();

+ ${member_name}.Remove(agent);

+ ${has_member_name} = !${member_name}.IsEmpty();

}

""")

@@ -276,7 +276,7 @@ class Method:

return template_agent_call.substitute(

None,

- name=self.name,

+ name=self.name[0].upper() + self.name[1:],

agent_class=agent_class,

agent_getter=agent_getter,

maybe_return=maybe_return,

@@ -392,7 +392,7 @@ def generate_instrumenting_agents(used_agents):

member_list.append(" HeapHashSet<Member<%s>> %s;" % (class_name, member_name))

member_list.append(" bool %s;" % has_member_name)

init_list.append("%s(false)" % has_member_name)

- trace_list.append("visitor->trace(%s);" % member_name)

+ trace_list.append("visitor->Trace(%s);" % member_name)

impl_list.append(template_instrumenting_agent_impl.substitute(

None,

class_name=class_name,