third_party/WebKit/Source/build/scripts/make_computed_style_base.py - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: Rebasing the fixes... Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/utilities.cpp.tmpl ('k') | third_party/WebKit/Source/build/scripts/make_css_property_metadata.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

index 2f2f84f8b0a5a85ef7683a4e2a3da410df3fec50..4b8056a674d564927eb4edf1f23a9e2d1507d1f3 100755

--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

@@ -122,9 +122,9 @@ def _create_property_field(property_):

# For now, the getter name should match the field name. Later, getter names

# will start with an uppercase letter, so if they conflict with the type name,

# add 'get' to the front.

- getter_method_name = property_name_lower

+ getter_method_name = property_['getter']

if type_name == property_name:

- getter_method_name = 'get' + property_name

+ getter_method_name = 'Get' + property_name

assert property_['initial_keyword'] is not None, \

('MakeComputedStyleBase requires an initial keyword for keyword_only values, none specified '

@@ -143,10 +143,10 @@ def _create_property_field(property_):

size=int(math.ceil(bits_needed)),

default_value=default_value,

getter_method_name=getter_method_name,

- setter_method_name='set' + property_name,

- initial_method_name='initial' + property_name,

- resetter_method_name='reset' + property_name,

- is_inherited_method_name=property_name_lower + 'IsInherited',

+ setter_method_name='Set' + property_name,

+ initial_method_name='Initial' + property_name,

+ resetter_method_name='Reset' + property_name,

+ is_inherited_method_name=property_name + 'IsInherited',

)

@@ -169,10 +169,10 @@ def _create_inherited_flag_field(property_):

storage_type_path=None,

size=1,

default_value='true',

- getter_method_name=field_name_suffix_lower,

- setter_method_name='set' + field_name_suffix_upper,

- initial_method_name='initial' + field_name_suffix_upper,

- resetter_method_name='reset' + field_name_suffix_upper,

+ getter_method_name=field_name_suffix_upper,

+ setter_method_name='Set' + field_name_suffix_upper,

+ initial_method_name='Initial' + field_name_suffix_upper,

+ resetter_method_name='Reset' + field_name_suffix_upper,

)