Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)
Patch Set: Rebasing the fixes... Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
index 525192f669beabe080476a840ed4dcbb787b02fb..ee8e778645dc84b550a5acd24388753c4a15e55d 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
@@ -51,7 +51,7 @@ def callback_function_context(callback_function):
'return_value': idl_type.v8_value_to_local_cpp_value(
callback_function.extended_attributes,
'v8ReturnValue', 'cppValue',
- isolate='m_scriptState->isolate()',
+ isolate='m_scriptState->GetIsolate()',
bailout_return_value='false'),
})
@@ -64,8 +64,8 @@ def arguments_context(arguments, return_cpp_type):
return {
'argument_name': '%sArgument' % argument.name,
'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value(
- argument.name, isolate='m_scriptState->isolate()',
- creation_context='m_scriptState->context()->Global()'),
+ argument.name, isolate='m_scriptState->GetIsolate()',
+ creation_context='m_scriptState->GetContext()->Global()'),
}
argument_declarations = [

Powered by Google App Engine
This is Rietveld 408576698