third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: Rebasing the fixes... Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h ('k') | third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp b/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

index 66ddf1032c2a0efc7bee5a51c8232faea2c78cf3..f4176766752aff952a1e5fdf1e2600841191843e 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

@@ -44,7 +44,8 @@ void V8IDBObserver::constructorCustom(

ScriptState* scriptState = ScriptState::forReceiverObject(info);

v8::Local<v8::Function> v8Callback = v8::Local<v8::Function>::Cast(info[0]);

IDBObserverCallback* callback =

- IDBObserverCallback::create(scriptState, v8Callback);

+ // DO NOT SUBMIT - merge marker - please spell |Create| below.

+ IDBObserverCallback::Create(scriptState, v8Callback);

IDBObserver* observer = IDBObserver::create(callback);

if (exceptionState.hadException())

return;