pkg/analyzer/lib/src/dart/constant/evaluation.dart - Issue 2329463002: Remove JavaPatternMatcher from java_core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/dart/constant/evaluation.dart

Issue 2329463002: Remove JavaPatternMatcher from java_core. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/dart/constant/evaluation.dart

diff --git a/pkg/analyzer/lib/src/dart/constant/evaluation.dart b/pkg/analyzer/lib/src/dart/constant/evaluation.dart

index 8c48f497acbdd6785c49fdbb68b7ba0125aef0ab..1120429cfd83fcea0f8a2599458a55b4fd9d8872 100644

--- a/pkg/analyzer/lib/src/dart/constant/evaluation.dart

+++ b/pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -861,7 +861,7 @@ class ConstantEvaluationEngine {

static bool isValidPublicSymbol(String name) =>

name.isEmpty ||

name == "void" ||

- new JavaPatternMatcher(_PUBLIC_SYMBOL_PATTERN, name).matches();

+ _PUBLIC_SYMBOL_PATTERN.hasMatch(name);

}

/**

« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/java_core.dart » ('j') | no next file with comments »