[Command buffer] During blit FB, It is invalid if src source and dst source have identical image

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 7583 matching lines @@
   }
 
   GLsizei read_buffer_samples = GetBoundFramebufferSamples(GL_READ_FRAMEBUFFER);
   if (read_buffer_samples > 0 &&
       (srcX0 != dstX0 || srcY0 != dstY0 || srcX1 != dstX1 || srcY1 != dstY1)) {
     LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
         "src framebuffer is multisampled, but src/dst regions are different");
     return;
   }
 
+  // Check whether read framebuffer and draw framebuffer have identical image
+  enum FeedbackLoopState {
+    FeedbackLoopTrue,
+    FeedbackLoopFalse,
+    FeedbackLoopUnknown
+  };
+
+  FeedbackLoopState is_feedback_loop = FeedbackLoopUnknown;
+  Framebuffer* read_framebuffer =
+      framebuffer_state_.bound_read_framebuffer.get();
+  Framebuffer* draw_framebuffer =
+      framebuffer_state_.bound_draw_framebuffer.get();
+  // If both read framebuffer and draw framebuffer are default framebuffer,
+  // They always have identical image. Otherwise, if one of read framebuffer
+  // and draw framebuffe is default framebuffer, but the other is fbo, they
+  // always have no identical image.
+  if (!read_framebuffer && !draw_framebuffer) {
+    is_feedback_loop = FeedbackLoopTrue;
+  } else if (!read_framebuffer || !draw_framebuffer) {
+    is_feedback_loop = FeedbackLoopFalse;
+  }
+  if ((mask & GL_DEPTH_BUFFER_BIT) != 0) {
+    const Framebuffer::Attachment* depth_buffer_read =
+        read_framebuffer->GetAttachment(GL_DEPTH_ATTACHMENT);
+    const Framebuffer::Attachment* depth_buffer_draw =
+        draw_framebuffer->GetAttachment(GL_DEPTH_ATTACHMENT);
+    if (depth_buffer_draw &&
+        depth_buffer_draw->IsSameAttachment(depth_buffer_read)) {
+      is_feedback_loop = FeedbackLoopTrue;
+    }
+  }
+  if ((mask & GL_STENCIL_BUFFER_BIT) != 0) {
+    const Framebuffer::Attachment* stencil_buffer_read =
+        read_framebuffer->GetAttachment(GL_STENCIL_ATTACHMENT);
+    const Framebuffer::Attachment* stencil_buffer_draw =
+        draw_framebuffer->GetAttachment(GL_STENCIL_ATTACHMENT);
+    if (stencil_buffer_draw &&
+        stencil_buffer_draw->IsSameAttachment(stencil_buffer_read)) {
+      is_feedback_loop = FeedbackLoopTrue;
+    }
+  }
+
   GLenum src_format = GetBoundReadFramebufferInternalFormat();
   GLenum src_type = GetBoundReadFramebufferTextureType();
 
   if ((mask & GL_COLOR_BUFFER_BIT) != 0) {
     bool is_src_signed_int = GLES2Util::IsSignedIntegerFormat(src_format);
     bool is_src_unsigned_int = GLES2Util::IsUnsignedIntegerFormat(src_format);
     DCHECK(!is_src_signed_int || !is_src_unsigned_int);
 
     if ((is_src_signed_int || is_src_unsigned_int) && filter == GL_LINEAR) {
       LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
                          "invalid filter for integer format");
       return;
     }
 
     GLenum src_sized_format =
         GLES2Util::ConvertToSizedFormat(src_format, src_type);
+    const Framebuffer::Attachment* read_buffer =
+        is_feedback_loop == FeedbackLoopUnknown ?
+        read_framebuffer->GetReadBufferAttachment() : nullptr;
     for (uint32_t ii = 0; ii < group_->max_draw_buffers(); ++ii) {
       GLenum dst_format = GetBoundColorDrawBufferInternalFormat(
           static_cast<GLint>(ii));
       GLenum dst_type = GetBoundColorDrawBufferType(static_cast<GLint>(ii));
       if (dst_format == 0)
         continue;
       if (read_buffer_samples > 0 &&
           (src_sized_format !=
            GLES2Util::ConvertToSizedFormat(dst_format, dst_type))) {
         LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
                            "src and dst formats differ for color");
         return;
       }
       bool is_dst_signed_int = GLES2Util::IsSignedIntegerFormat(dst_format);
       bool is_dst_unsigned_int = GLES2Util::IsUnsignedIntegerFormat(dst_format);
       DCHECK(!is_dst_signed_int || !is_dst_unsigned_int);
       if (is_src_signed_int != is_dst_signed_int ||
           is_src_unsigned_int != is_dst_unsigned_int) {
         LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
                            "incompatible src/dst color formats");
         return;
       }
+      // Check whether draw buffers have identical color image with read buffer
+      if (is_feedback_loop == FeedbackLoopUnknown) {
+        GLenum drawbuffer = static_cast<GLenum>(GL_DRAW_BUFFER0 + ii);
+        if (draw_framebuffer->GetDrawBuffer(drawbuffer) == GL_NONE) {
+          continue;
+        }
+        GLenum attachment = static_cast<GLenum>(GL_COLOR_ATTACHMENT0 + ii);
+        const Framebuffer::Attachment* draw_buffer =
+            draw_framebuffer->GetAttachment(attachment);
+        if (!draw_buffer) {
+          continue;
+        }
+        if (draw_buffer->IsSameAttachment(read_buffer)) {
+          is_feedback_loop = FeedbackLoopTrue;

[Zhenyao Mo, 2016/09/12 05:37:08]

nit: break

[yunchao, 2016/09/12 06:01:51]

Done.

+        }
+      }
     }
   }
+  if (is_feedback_loop == FeedbackLoopTrue) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
+        "source buffer and destination buffers are identical");
+    return;
+  }
 
   if ((mask & (GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT)) != 0) {
     if (filter != GL_NEAREST) {
       LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
                          "invalid filter for depth/stencil");
       return;
     }
 
     if ((GetBoundFramebufferDepthFormat(GL_READ_FRAMEBUFFER) !=
          GetBoundFramebufferDepthFormat(GL_DRAW_FRAMEBUFFER)) ||
@@ skipping 10280 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu