[Command buffer] During blit FB, It is invalid if src source and dst source have identical image

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 1331 matching lines @@
   // Infer color encoding from internalformat
   static GLint GetColorEncodingFromInternalFormat(GLenum internalformat);
 
   // Check that the currently bound read framebuffer's color image
   // isn't the target texture of the glCopyTex{Sub}Image{2D|3D}.
   bool FormsTextureCopyingFeedbackLoop(
       TextureRef* texture,
       GLint level,
       GLint layer);
 
+  // Check that whether the currently bound draw framebuffer has image

[Zhenyao Mo, 2016/09/09 16:29:57]

nit: remove that

[yunchao, 2016/09/09 16:47:33]

Done.

+  // that is identical to the read framebuffer's image for blitFramebuffer,
+  // and only check the designated image type by parameter mask.
+  bool FormsFramebufferBlitingFeedbackLoop(GLbitfield mask);
+
   // Check if a framebuffer meets our requirements.
   // Generates |gl_error| if the framebuffer is incomplete.
   bool CheckFramebufferValid(
       Framebuffer* framebuffer,
       GLenum target,
       GLenum gl_error,
       const char* func_name);
 
   bool CheckBoundDrawFramebufferValid(const char* func_name);
   // Generates |gl_error| if the bound read fbo is incomplete.
@@ skipping 2963 matching lines @@
       framebuffer_state_.bound_draw_framebuffer.get();
   if (!framebuffer)
     return false;
   const Framebuffer::Attachment* attachment =
       framebuffer->GetReadBufferAttachment();
   if (!attachment)
     return false;
   return attachment->FormsFeedbackLoop(texture, level, layer);
 }
 
+bool GLES2DecoderImpl::FormsFramebufferBlitingFeedbackLoop(GLbitfield mask) {
+  Framebuffer* read_framebuffer =
+      framebuffer_state_.bound_read_framebuffer.get();
+  Framebuffer* draw_framebuffer =
+      framebuffer_state_.bound_draw_framebuffer.get();
+  // If both read framebuffer and draw framebuffer are default framebuffer,
+  // They always have the same image.
+  if (!read_framebuffer && !draw_framebuffer)
+    return true;
+  if (!read_framebuffer || !draw_framebuffer)
+    return false;
+  if ((mask & GL_COLOR_BUFFER_BIT) != 0) {
+    const Framebuffer::Attachment* read_buffer =
+        read_framebuffer->GetReadBufferAttachment();
+
+    for (uint32_t ii = 0; ii < group_->max_draw_buffers(); ++ii) {

[Zhenyao Mo, 2016/09/09 16:29:57]

If you go through attachments of the draw_framebuffer, most time it's probably
only one or two attachments, much less iterations.

[yunchao, 2016/09/09 16:47:33]

That's true. But we still need to iterate to cover unusual cases... 

[Zhenyao Mo, 2016/09/09 17:39:32]

We should always optimize against most common use cases. BlitFramebuffer is on
critical path: if webgl is created with antialias = true, then each frame we
need to blit to a non-multisampled texture for compositing. So optimizing it is
important.

+      GLenum drawbuffer = static_cast<GLenum>(GL_DRAW_BUFFER0 + ii);
+      if (draw_framebuffer->GetDrawBuffer(drawbuffer) == GL_NONE) {
+        continue;
+      }
+      GLenum attachment = static_cast<GLenum>(GL_COLOR_ATTACHMENT0 + ii);
+      const Framebuffer::Attachment* draw_buffer =
+          draw_framebuffer->GetAttachment(attachment);
+      if (!draw_buffer) {
+        continue;
+      }
+      if (draw_buffer->IsSameAttachment(read_buffer)) {
+        return true;
+      }
+    }
+  }
+  if ((mask & GL_DEPTH_BUFFER_BIT) != 0) {
+    const Framebuffer::Attachment* depth_buffer_read =
+        read_framebuffer->GetAttachment(GL_DEPTH_ATTACHMENT);
+    const Framebuffer::Attachment* depth_buffer_draw =
+        draw_framebuffer->GetAttachment(GL_DEPTH_ATTACHMENT);
+      if (depth_buffer_draw &&

[Zhenyao Mo, 2016/09/09 16:29:57]

nit: wrong indent

[yunchao, 2016/09/09 16:47:33]

Done.

+          depth_buffer_draw->IsSameAttachment(depth_buffer_read)) {
+      return true;
+    }
+  }
+  if ((mask & GL_STENCIL_BUFFER_BIT) != 0) {
+    const Framebuffer::Attachment* stencil_buffer_read =
+        read_framebuffer->GetAttachment(GL_STENCIL_ATTACHMENT);
+    const Framebuffer::Attachment* stencil_buffer_draw =
+        draw_framebuffer->GetAttachment(GL_STENCIL_ATTACHMENT);
+    if (stencil_buffer_draw &&
+        stencil_buffer_draw->IsSameAttachment(stencil_buffer_read)) {
+      return true;
+    }
+  }
+  return false;
+}
+
 gfx::Size GLES2DecoderImpl::GetBoundReadFramebufferSize() {
   Framebuffer* framebuffer =
       GetFramebufferInfoForTarget(GL_READ_FRAMEBUFFER_EXT);
   if (framebuffer != NULL) {
     const Framebuffer::Attachment* attachment =
         framebuffer->GetReadBufferAttachment();
     if (attachment) {
       return gfx::Size(attachment->width(), attachment->height());
     }
     return gfx::Size(0, 0);
@@ skipping 3247 matching lines @@
   }
 
   GLsizei read_buffer_samples = GetBoundFramebufferSamples(GL_READ_FRAMEBUFFER);
   if (read_buffer_samples > 0 &&
       (srcX0 != dstX0 || srcY0 != dstY0 || srcX1 != dstX1 || srcY1 != dstY1)) {
     LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
         "src framebuffer is multisampled, but src/dst regions are different");
     return;
   }
 
+  if (FormsFramebufferBlitingFeedbackLoop(mask)) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
+        "source buffer and destination buffers are identical");
+    return;
+  }
+
   GLenum src_format = GetBoundReadFramebufferInternalFormat();
   GLenum src_type = GetBoundReadFramebufferTextureType();
 
   if ((mask & GL_COLOR_BUFFER_BIT) != 0) {
     bool is_src_signed_int = GLES2Util::IsSignedIntegerFormat(src_format);
     bool is_src_unsigned_int = GLES2Util::IsUnsignedIntegerFormat(src_format);
     DCHECK(!is_src_signed_int || !is_src_unsigned_int);
 
     if ((is_src_signed_int || is_src_unsigned_int) && filter == GL_LINEAR) {
       LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, func_name,
@@ skipping 10317 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu