Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2329433002: Add use counter for offerToReceiveAudio/offerToReceiveVideo (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
index d14d58e0abfe7f31c29f1e1e2ded66f858a12f26..41045e9e9f543ac4cc9448177c4eefc03f082aef 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
@@ -500,6 +500,10 @@ ScriptPromise RTCPeerConnection::createOffer(ScriptState* scriptState, const RTC
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
RTCSessionDescriptionRequest* request = RTCSessionDescriptionRequestPromiseImpl::create(this, resolver);
+ if (options.hasOfferToReceiveAudio())
+ UseCounter::count(scriptState->getExecutionContext(), UseCounter::RTCPeerConnectionCreateOfferOptionsOfferToReceiveAudio);
Guido Urdaneta 2016/09/09 12:07:48 Would it be better to have a single counter and co
foolip 2016/09/09 12:17:00 Done.
+ if (options.hasOfferToReceiveVideo())
+ UseCounter::count(scriptState->getExecutionContext(), UseCounter::RTCPeerConnectionCreateOfferOptionsOfferToReceiveVideo);
m_peerHandler->createOffer(request, convertToWebRTCOfferOptions(options));
return promise;
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698