Add use counter for offerToReceiveAudio/offerToReceiveVideo

Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org

Committed: https://crrev.com/df9ac74e973c18da4270437a3eb6a6860c701f71
Cr-Commit-Position: refs/heads/master@{#417602}

[foolip, 2016-09-09 11:58:18]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 11:58:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2016-09-09 12:07:48]

https://codereview.chromium.org/2329433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
(right):

https://codereview.chromium.org/2329433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp:504:
UseCounter::count(scriptState->getExecutionContext(),
UseCounter::RTCPeerConnectionCreateOfferOptionsOfferToReceiveAudio);
Would it be better to have a single counter and count requests where any of the
two options are used?

[foolip, 2016-09-09 12:15:22]

Description was changed from

==========
Add use counters for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org,mkwst@chromium.org
==========

to

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org,mkwst@chromium.org
==========

[foolip, 2016-09-09 12:16:36]

Description was changed from

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org,mkwst@chromium.org
==========

to

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org,mkwst@chromium.org
==========

[foolip, 2016-09-09 12:17:00]

https://codereview.chromium.org/2329433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
(right):

https://codereview.chromium.org/2329433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp:504:
UseCounter::count(scriptState->getExecutionContext(),
UseCounter::RTCPeerConnectionCreateOfferOptionsOfferToReceiveAudio);
On 2016/09/09 12:07:48, Guido Urdaneta wrote:
> Would it be better to have a single counter and count requests where any of
the
> two options are used?

Done.

[foolip, 2016-09-09 12:17:18]

Description was changed from

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org,mkwst@chromium.org
==========

to

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org
==========

[foolip, 2016-09-09 12:17:18]

foolip@chromium.org changed reviewers:
+ jochen@chromium.org
- mkwst@chromium.org

[foolip, 2016-09-09 12:17:37]

jochen@, looks like mkwst@ is OOO, can you rs?

[Guido Urdaneta, 2016-09-09 12:18:12]

lgtm

[jochen (gone - plz use gerrit), 2016-09-09 13:19:42]

lgtm

[foolip, 2016-09-09 14:38:41]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-09-09 14:38:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 16:45:21]

Description was changed from

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org
==========

to

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org
==========

[commit-bot: I haz the power, 2016-09-09 16:45:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 16:48:15]

Description was changed from

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org
==========

to

==========
Add use counter for offerToReceiveAudio/offerToReceiveVideo

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org

Committed: https://crrev.com/df9ac74e973c18da4270437a3eb6a6860c701f71
Cr-Commit-Position: refs/heads/master@{#417602}
==========

[commit-bot: I haz the power, 2016-09-09 16:48:18]

Patchset 2 (id:??) landed as
https://crrev.com/df9ac74e973c18da4270437a3eb6a6860c701f71
Cr-Commit-Position: refs/heads/master@{#417602}