Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2329403003: More features handled in kernel impact. (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix analyze_test_test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -26 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +0 lines, -10 lines 0 comments Download
A pkg/compiler/lib/src/kernel/kernel_debug.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 2 2 chunks +17 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 2 2 chunks +27 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/feature.dart View 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_test_test.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 4 chunks +55 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 3 months ago (2016-09-12 13:54:24 UTC) #2
Harry Terkelsen
lgtm
4 years, 3 months ago (2016-09-12 16:52:42 UTC) #3
Johnni Winther
4 years, 3 months ago (2016-09-16 10:52:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4eca725670652ee3f5066e587b830b102f9645c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698