[Chrome OS MD] Enable the brightness row to be visible at all times

Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all
time for Chrome OS MD; the visibility stays as it is for non-MD.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809
Committed: https://crrev.com/abe996a2265a521e1705f3ba44e1398de70df461
Cr-Commit-Position: refs/heads/master@{#417975}

[yiyix, 2016-09-11 21:55:33]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-11 21:55:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2016-09-11 22:10:19]

Description was changed from

==========
implementation

BUG=
==========

to

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all time.

BUG=631809
==========

[commit-bot: I haz the power, 2016-09-11 22:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-11 22:33:34]

Dry run: This issue passed the CQ dry run.

[yiyix, 2016-09-12 04:26:28]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[yiyix, 2016-09-12 04:26:35]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-09-12 04:26:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2016-09-12 04:27:55]

Description was changed from

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all time.

BUG=631809
==========

to

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all time.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809
==========

[commit-bot: I haz the power, 2016-09-12 05:28:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 05:28:27]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-09-12 05:28:28]

Dry run: This issue passed the CQ dry run.

[yiyix, 2016-09-12 05:57:42]

yiyix@chromium.org changed reviewers:
+ tdanderson@chromium.org

[yiyix, 2016-09-12 05:57:43]

@tdanderson, could you please take a look at this change?
Thanks.

[tdanderson, 2016-09-12 15:54:49]

lgtm after two comments are addressed below.

https://chromiumcodereview.appspot.com/2329333002/diff/20001/ash/common/syste...
File ash/common/system/chromeos/brightness/tray_brightness.cc (right):

https://chromiumcodereview.appspot.com/2329333002/diff/20001/ash/common/syste...
ash/common/system/chromeos/brightness/tray_brightness.cc:1: // Copyright 2013
The Chromium Authors. All rights reserved.
nit: in the CL description say that the change is just for MD, and non-MD stays
as-is.

https://chromiumcodereview.appspot.com/2329333002/diff/20001/ash/common/syste...
ash/common/system/chromeos/brightness/tray_brightness.cc:52: // changes. See
crbug.com/614453.
Good catch, and thanks for add this TODO.

https://chromiumcodereview.appspot.com/2329333002/diff/20001/ash/common/syste...
ash/common/system/chromeos/brightness/tray_brightness.cc:130: bool show_icon =
!icon->GetImage().isNull();
I don't think this check is necessary; you just be able to just say
SetVisible(true);

[yiyix, 2016-09-12 17:31:15]

Description was changed from

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all time.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809
==========

to

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all 
time for Chrome OS MD; the visibility stays as it is for non-MD.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809
==========

[yiyix, 2016-09-12 17:31:24]

https://codereview.chromium.org/2329333002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/brightness/tray_brightness.cc (right):

https://codereview.chromium.org/2329333002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/brightness/tray_brightness.cc:1: // Copyright 2013
The Chromium Authors. All rights reserved.
On 2016/09/12 15:54:49, tdanderson wrote:
> nit: in the CL description say that the change is just for MD, and non-MD
stays
> as-is.

Done.

https://codereview.chromium.org/2329333002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/brightness/tray_brightness.cc:52: // changes. See
crbug.com/614453.
On 2016/09/12 15:54:49, tdanderson wrote:
> Good catch, and thanks for add this TODO.

:) thanks

https://codereview.chromium.org/2329333002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/brightness/tray_brightness.cc:130: bool show_icon =
!icon->GetImage().isNull();
On 2016/09/12 15:54:49, tdanderson wrote:
> I don't think this check is necessary; you just be able to just say
> SetVisible(true);

Done.

[yiyix, 2016-09-12 17:33:49]

The CQ bit was checked by yiyix@chromium.org

[yiyix, 2016-09-12 17:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2329333002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-12 17:34:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:18:38]

Description was changed from

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all 
time for Chrome OS MD; the visibility stays as it is for non-MD.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809
==========

to

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all 
time for Chrome OS MD; the visibility stays as it is for non-MD.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809
==========

[commit-bot: I haz the power, 2016-09-12 18:18:40]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-12 18:20:33]

Description was changed from

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all 
time for Chrome OS MD; the visibility stays as it is for non-MD.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809
==========

to

==========
Enable the brightness row to be visible at all times

Update the visibility of the the brightness row to be visible at all
time for Chrome OS MD; the visibility stays as it is for non-MD.

TEST=Tray_brightness_unittests in ash_unittests

BUG=631809

Committed: https://crrev.com/abe996a2265a521e1705f3ba44e1398de70df461
Cr-Commit-Position: refs/heads/master@{#417975}
==========

[commit-bot: I haz the power, 2016-09-12 18:20:34]

Patchset 2 (id:??) landed as
https://crrev.com/abe996a2265a521e1705f3ba44e1398de70df461
Cr-Commit-Position: refs/heads/master@{#417975}