Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc

Issue 2329303002: Delete obsolete AllowedDeviceModes enrollment parameter. (Closed)
Patch Set: Fix tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/device_cloud_policy_initializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
diff --git a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
index b9ef172a1b2b855f190da790289a6b7e59ce4a20..45c25932b6299b7a041c724a2961adbe0b33a697 100644
--- a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
+++ b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
@@ -157,16 +157,12 @@ void EnterpriseEnrollmentHelperImpl::DoEnroll(const std::string& token) {
return;
}
- policy::DeviceCloudPolicyInitializer::AllowedDeviceModes device_modes;
- device_modes[policy::DEVICE_MODE_ENTERPRISE] = true;
connector->ScheduleServiceInitialization(0);
-
policy::DeviceCloudPolicyInitializer* dcp_initializer =
connector->GetDeviceCloudPolicyInitializer();
CHECK(dcp_initializer);
achuithb 2016/09/12 18:15:40 Curious: why do we have this CHECK? The next line
Thiemo Nagel 2016/09/12 18:23:56 Dereferencing a nullptr is undefined behavior. If
dcp_initializer->StartEnrollment(
connector->device_management_service(), enrollment_config_, token,
- device_modes,
base::Bind(&EnterpriseEnrollmentHelperImpl::OnEnrollmentFinished,
weak_ptr_factory_.GetWeakPtr()));
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/device_cloud_policy_initializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698