Delete obsolete AllowedDeviceModes enrollment parameter.

Delete obsolete AllowedDeviceModes enrollment parameter.

Also remove (apparently obsolete) code to tolerate unset device mode in
registration responses.

BUG=none

Committed: https://crrev.com/346b5074244fdff1ea41ac91b5548553790ec3c2
Cr-Commit-Position: refs/heads/master@{#417977}

[Thiemo Nagel, 2016-09-11 19:22:40]

tnagel@chromium.org changed reviewers:
+ igorcov@chromium.org

[Thiemo Nagel, 2016-09-11 19:22:41]

Hi Igor,

could you please review?

Thank you,
Thiemo

https://codereview.chromium.org/2329303002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc (left):

https://codereview.chromium.org/2329303002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc:187: if
(device_mode_ == DEVICE_MODE_NOT_SET)
Mattias, do you remember why the client tolerates an unset device mode in the
registration response?

[Thiemo Nagel, 2016-09-11 19:23:12]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-11 19:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-11 20:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-11 20:04:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Thiemo Nagel, 2016-09-11 20:46:41]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-11 20:46:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-11 21:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-11 21:31:18]

Dry run: This issue passed the CQ dry run.

[Mattias Nissler (ping if slow), 2016-09-12 07:01:20]

mnissler@chromium.org changed reviewers:
+ mnissler@chromium.org

[Mattias Nissler (ping if slow), 2016-09-12 07:01:21]

https://codereview.chromium.org/2329303002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc (left):

https://codereview.chromium.org/2329303002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc:187: if
(device_mode_ == DEVICE_MODE_NOT_SET)
On 2016/09/11 19:22:41, Thiemo Nagel (slow) wrote:
> Mattias, do you remember why the client tolerates an unset device mode in the
> registration response?

Not exactly, but I suspect we wrote the client-side code before the server
supported the field.

[igorcov, 2016-09-12 13:52:24]

LGTM

[Thiemo Nagel, 2016-09-12 16:26:57]

Description was changed from

==========
Delete obsolete AllowedDeviceModes enrollment parameter.

Also remove (apparently obsolete) code to tolerate unset device mode in
registration responses.

BUG=nonne
==========

to

==========
Delete obsolete AllowedDeviceModes enrollment parameter.

Also remove (apparently obsolete) code to tolerate unset device mode in
registration responses.

BUG=none
==========

[Thiemo Nagel, 2016-09-12 16:28:39]

tnagel@chromium.org changed reviewers:
+ achuith@chromium.org

[Thiemo Nagel, 2016-09-12 16:28:39]

Hi Achuith,

could you please take a look?

Thank you!
Thiemo

[achuithb, 2016-09-12 18:15:40]

lgtm

https://codereview.chromium.org/2329303002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
(right):

https://codereview.chromium.org/2329303002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc:163:
CHECK(dcp_initializer);
Curious: why do we have this CHECK? The next line crashes on null. I know this
is not your code so you can ignore this if you like.

[Thiemo Nagel, 2016-09-12 18:23:56]

Thank you, Achuith!

https://codereview.chromium.org/2329303002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
(right):

https://codereview.chromium.org/2329303002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc:163:
CHECK(dcp_initializer);
On 2016/09/12 18:15:40, achuithb wrote:
> Curious: why do we have this CHECK? The next line crashes on null. I know this
> is not your code so you can ignore this if you like.

Dereferencing a nullptr is undefined behavior.  If we want to crash on nullptr,
it should be made explicit by CHECK().  Relying on nullptr dereference to crash
can be dangerous.  I don't think it's good style.

[Thiemo Nagel, 2016-09-12 18:24:09]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:24:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:29:19]

Description was changed from

==========
Delete obsolete AllowedDeviceModes enrollment parameter.

Also remove (apparently obsolete) code to tolerate unset device mode in
registration responses.

BUG=none
==========

to

==========
Delete obsolete AllowedDeviceModes enrollment parameter.

Also remove (apparently obsolete) code to tolerate unset device mode in
registration responses.

BUG=none
==========

[commit-bot: I haz the power, 2016-09-12 18:29:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 18:30:39]

Description was changed from

==========
Delete obsolete AllowedDeviceModes enrollment parameter.

Also remove (apparently obsolete) code to tolerate unset device mode in
registration responses.

BUG=none
==========

to

==========
Delete obsolete AllowedDeviceModes enrollment parameter.

Also remove (apparently obsolete) code to tolerate unset device mode in
registration responses.

BUG=none

Committed: https://crrev.com/346b5074244fdff1ea41ac91b5548553790ec3c2
Cr-Commit-Position: refs/heads/master@{#417977}
==========

[commit-bot: I haz the power, 2016-09-12 18:30:40]

Patchset 2 (id:??) landed as
https://crrev.com/346b5074244fdff1ea41ac91b5548553790ec3c2
Cr-Commit-Position: refs/heads/master@{#417977}