[Android] Adds python option for EMMA coverage

build/android/pylib/constants.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Defines a set of constants shared by test runners and other scripts."""
 
 import os
 import subprocess
 import sys
 
 
 DIR_SOURCE_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__),
                                                os.pardir, os.pardir, os.pardir))
 ISOLATE_DEPS_DIR = os.path.join(DIR_SOURCE_ROOT, 'isolate_deps_dir')
 EMULATOR_SDK_ROOT = os.path.abspath(os.path.join(DIR_SOURCE_ROOT, os.pardir,
                                                  os.pardir))
-
 CHROME_PACKAGE = 'com.google.android.apps.chrome'
 CHROME_ACTIVITY = 'com.google.android.apps.chrome.Main'
 CHROME_DEVTOOLS_SOCKET = 'chrome_devtools_remote'
 
 CHROME_TESTS_PACKAGE = 'com.google.android.apps.chrome.tests'
 
 LEGACY_BROWSER_PACKAGE = 'com.google.android.browser'
 LEGACY_BROWSER_ACTIVITY = 'com.android.browser.BrowserActivity'
 
 CONTENT_SHELL_PACKAGE = 'org.chromium.content_shell_apk'
@@ skipping 59 matching lines @@
   try:
     return os.environ['BUILDTYPE']
   except KeyError:
     raise Exception('The BUILDTYPE environment variable has not been set')
 
 
 def SetBuildType(build_type):
   os.environ['BUILDTYPE'] = build_type
 
 
+def GetCoverageDir(build_type=None):

[frankf, 2013/08/20 18:30:47]

Where is this used?

[gkanwar1, 2013/08/20 18:37:13]

This is used by the buildbot scripts. I put it with this CL, since that one will
be the most time-constrained at the end, and the fewer changes included in it,
the better.

[frankf, 2013/08/20 18:47:43]

Why do you need to take build_type as parameter?

On 2013/08/20 18:37:13, gkanwar1 wrote:

[gkanwar1, 2013/08/20 18:56:18]

Test-generated files (like logs, etc.) generally are placed into the
out/<target> folder, rather than the top-level out folder, so this needs to
accept build_type to place it in the correct folder.

+  if not build_type:
+    build_type = GetBuildType()
+  return os.path.join(DIR_SOURCE_ROOT, 'out', build_type, 'coverage')
+
+
 def _GetADBPath():
   if os.environ.get('ANDROID_SDK_ROOT'):
     return 'adb'
   # If envsetup.sh hasn't been sourced and there's no adb in the path,
   # set it here.
   try:
     with file(os.devnull, 'w') as devnull:
       subprocess.call(['adb', 'version'], stdout=devnull, stderr=devnull)
     return 'adb'
   except OSError:
     print >> sys.stderr, 'No adb found in $PATH, fallback to checked in binary.'
     return os.path.join(ANDROID_SDK_ROOT, 'platform-tools', 'adb')
 
 
 ADB_PATH = _GetADBPath()
 
 # Exit codes
 ERROR_EXIT_CODE = 1
 WARNING_EXIT_CODE = 88