[Android] Adds python option for EMMA coverage

build/android/generate_emma_html.py

+#!/usr/bin/env python
+
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Aggregates EMMA coverage files to produce html output."""
+
+import fnmatch
+import json
+import optparse
+import os
+import sys
+
+from pylib import cmd_helper
+from pylib import constants
+
+
+def _GetFilesWithExt(root_dir, ext):
+  """Gets all files with a given extension.
+
+  Args:
+    root_dir: Directory in which to search for files.
+    ext: Extension to look for (including dot)
+
+  Returns:
+    A list of absolute paths to files that match.
+  """
+  files = []
+  for root, _, filenames in os.walk(root_dir):
+    basenames = fnmatch.filter(filenames, '*.' + ext)
+    files.extend([os.path.join(root, basename)
+                  for basename in basenames])
+
+  return files
+
+
+def main(argv):
+  option_parser = optparse.OptionParser()
+  option_parser.add_option('-o', '--output', help='HTML output filename.')
+  option_parser.add_option('-c', '--coverage-dir', default=None,
+                           help=('Root of the directory in which to search for '
+                                 'coverage data (.ec) files.'))
+  option_parser.add_option('-m', '--metadata-dir', default=None,
+                           help=('Root of the directory in which to search for '
+                                 'coverage metadata (.em) files.'))
+  options, args = option_parser.parse_args()
+
+  if not (options.coverage_dir and options.metadata_dir and options.output):
+    option_parser.error('All arguments are required.')
+
+  coverage_files = _GetFilesWithExt(options.coverage_dir, 'ec')
+  metadata_files = _GetFilesWithExt(options.metadata_dir, 'em')
+  print 'Found coverage files: %s' % str(coverage_files)
+  print 'Found metadata files: %s' % str(metadata_files)
+  sources_files = []
+  for f in metadata_files:
+    sources_file = os.path.join(os.path.dirname(f), 'emma_sources.txt')
+    if os.path.exists(sources_file):

[frankf, 2013/08/20 18:30:47]

when would this not exist?

[gkanwar1, 2013/08/20 18:37:13]

It shouldn't ever not exist, since the metadata and sources files should be
generated at the same time, but in the name of robustness in case of future
changes I thought it would be a good idea to just put a check here instead of
failing. Perhaps we want it to fail so it is noticed if someone makes a change
to the coverage build system?

[frankf, 2013/08/20 18:47:43]

Right, robustness only makes sense if there are expected failure cases. It's
better to throw a exception instead of sweeping it under the rug. Please
consider robustness on the buildbot side though with GS which is expected to
fail.

On 2013/08/20 18:37:13, gkanwar1 wrote:

[gkanwar1, 2013/08/20 18:56:18]

Okay, removed the check.

+      with open(sources_file, 'r') as f:
+        sources_files.extend(json.load(f))
+  sources_files = [os.path.join(constants.DIR_SOURCE_ROOT, s)
+                   for s in sources_files]
+
+  input_args = []
+  for f in coverage_files + metadata_files:
+    input_args.append('-in')
+    input_args.append(f)
+
+  output_args = ['-Dreport.html.out.file', options.output]
+  source_args = ['-sp', ','.join(sources_files)]
+
+  return cmd_helper.RunCmd(
+      ['java', '-cp',
+       os.path.join(constants.ANDROID_SDK_ROOT, 'tools', 'lib', 'emma.jar'),
+       'emma', 'report', '-r', 'html']
+      + input_args + output_args + source_args)
+
+
+if __name__ == '__main__':
+  sys.exit(main(sys.argv))