Issue 23293002: Remove linker warning when getpid() is including.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23293002: Remove linker warning when getpid() is including. (Closed)

Created:
7 years, 4 months ago by Sam Clegg

Modified:
7 years, 3 months ago

Reviewers:
Mark Seaborn

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master

Visibility:
Public.

Remove linker warning when getpid() is including. When getpid() was recently added to the NaCl port it mistakenly included a stub_warning() which causes any programs that reference it to produce a linker warning. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2488 R=mseaborn@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=6943874

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	sysdeps/nacl/getpid.c	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Mark Seaborn

On 2013/08/16 18:13:19, Mark Seaborn wrote: > LGTM Ping -- can you commit this to ...

7 years, 3 months ago (2013-09-12 00:13:18 UTC) #3

Sam Clegg

7 years, 3 months ago (2013-09-12 15:36:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r6943874 (presubmit successful).