Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2329283002: [Offline pages] OPM SQL store: moving load to constructor, updating read to GetOfflinePages (Closed)
Patch Set: Addressing CR feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index 25f2e08a68de91249597a5a83ee048cdcde3bb42..d9ee55e5536d17c26737db944ecbb895635b2505 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -771,8 +771,9 @@ void OfflinePageModelImpl::OnEnsureArchivesDirCreatedDone(
UMA_HISTOGRAM_TIMES("OfflinePages.Model.ArchiveDirCreationTime",
base::TimeTicks::Now() - start_time);
- store_->Load(base::Bind(&OfflinePageModelImpl::OnLoadDone,
- weak_ptr_factory_.GetWeakPtr(), start_time));
+ store_->GetOfflinePages(base::Bind(&OfflinePageModelImpl::OnLoadDone,
+ weak_ptr_factory_.GetWeakPtr(),
+ start_time));
}
void OfflinePageModelImpl::OnLoadDone(
@@ -1004,8 +1005,9 @@ void OfflinePageModelImpl::OnResetStoreDoneForClearAll(
}
offline_pages_.clear();
- store_->Load(base::Bind(&OfflinePageModelImpl::OnReloadStoreDoneForClearAll,
- weak_ptr_factory_.GetWeakPtr(), callback));
+ store_->GetOfflinePages(
+ base::Bind(&OfflinePageModelImpl::OnReloadStoreDoneForClearAll,
+ weak_ptr_factory_.GetWeakPtr(), callback));
}
void OfflinePageModelImpl::OnReloadStoreDoneForClearAll(
« no previous file with comments | « components/offline_pages/offline_page_metadata_store_sql.cc ('k') | components/offline_pages/offline_page_test_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698