Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2329263002: Run format-webkitpy and fix long lines. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run format-webkitpy and fix long lines. Specifically: I ran format-webkitpy --leave-strings-alone on the codebase, and discovered that autopep8 doesn't automatically break long lines in some circumstances. (yapf breaks up more long lines, but I think it's too aggressive, and reformats things in ways that I don't like sometimes.) BUG=643937 Committed: https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af Cr-Commit-Position: refs/heads/master@{#418022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+952 lines, -447 lines) Patch
M third_party/WebKit/Tools/Scripts/check-testharness-expected-pass View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json_test.py View 2 chunks +26 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py View 4 chunks +190 lines, -145 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/read_checksum_from_png_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py View 3 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 4 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 6 chunks +31 lines, -24 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 4 chunks +33 lines, -17 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_input.py View 1 chunk +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py View 2 chunks +72 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py View 3 chunks +144 lines, -51 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 5 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 2 chunks +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py View 1 chunk +125 lines, -20 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 5 chunks +19 lines, -14 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py View 7 chunks +34 lines, -15 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 10 chunks +72 lines, -48 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png_unittest.py View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines_unittest.py View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_test.py View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commit_announcer.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests.py View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py View 2 chunks +19 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py View 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
qyearsley
4 years, 3 months ago (2016-09-12 16:21:14 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-12 18:53:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329263002/1
4 years, 3 months ago (2016-09-12 20:04:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 20:12:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 20:15:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/721212bf1af3f3bed906f8aa86ee1980c3f5c6af
Cr-Commit-Position: refs/heads/master@{#418022}

Powered by Google App Engine
This is Rietveld 408576698