third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h - Issue 2329243002: Implement WTF::WeakPtr in terms of base::WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h

Issue 2329243002: Implement WTF::WeakPtr in terms of base::WeakPtr (Closed)

Patch Set: Thread-safety fix with comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h

diff --git a/third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h b/third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h

index d865782e3cdbf451475b9ebe38a4fcca5672fce5..0bd88cac8f90393b593b4dab79e8fc1a4a224155 100644

--- a/third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h

+++ b/third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h

@@ -74,6 +74,7 @@ private:

Vector<std::pair<std::unique_ptr<ExecutionContextTask>, bool /* instrumenting */>> m_pendingTasks;

bool m_suspended;

WeakPtrFactory<MainThreadTaskRunner> m_weakFactory;

+ WeakPtr<MainThreadTaskRunner> m_weakPtr;

};

inline std::unique_ptr<MainThreadTaskRunner> MainThreadTaskRunner::create(ExecutionContext* context)