Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7540)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 23292002: Don't expose document.register to Chrome Apps by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweak RegisterElement Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 7eed1798cceed12f04cfe07ba9ea4965b9c7bce5..7615d778f894b0513f3a170f4682e769b6b199db 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -13,6 +13,7 @@ var eventBindings = require('event_bindings');
var WebRequestEvent = require('webRequestInternal').WebRequestEvent;
var webRequestSchema =
requireNative('schema_registry').GetSchema('webRequest');
+var WebviewNatives = requireNative('webview_natives');
// This secret enables hiding <webview> private members from the outside scope.
// Outside of this file, |secret| is inaccessible. The only way to access the
@@ -703,7 +704,7 @@ WebViewInternal.prototype.setupWebRequestEvents_ = function() {
// Save document.register in a variable in case the developer attempts to
dominicc (has gone to gerrit) 2013/08/17 00:13:12 This comment can go now. No author is going to ove
Fady Samuel 2013/08/20 23:00:39 Done.
// override it at some point.
-var register = document.register;
+var register = WebviewNatives.RegisterElement;
// Registers browser plugin <object> custom element.
function registerBrowserPluginElement() {

Powered by Google App Engine
This is Rietveld 408576698