Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2739)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 23292002: Don't expose document.register to Chrome Apps by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/document_custom_bindings.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 44454bde52f4a1f33e5107fb229042e7dc4228f0..4100f1a21421a97b4b58bceef04172d3b7342625 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -10,6 +10,7 @@
'use strict';
var eventBindings = require('event_bindings');
+var DocumentNatives = requireNative('document_natives');
var messagingNatives = requireNative('messaging_natives');
var WebRequestEvent = require('webRequestInternal').WebRequestEvent;
var webRequestSchema =
@@ -676,10 +677,6 @@ WebViewInternal.prototype.setupWebRequestEvents_ = function() {
);
};
-// Save document.register in a variable in case the developer attempts to
-// override it at some point.
-var register = document.register;
-
// Registers browser plugin <object> custom element.
function registerBrowserPluginElement() {
var proto = Object.create(HTMLObjectElement.prototype);
@@ -700,7 +697,7 @@ function registerBrowserPluginElement() {
};
WebViewInternal.BrowserPlugin =
- register.call(document, 'browser-plugin', {prototype: proto});
+ DocumentNatives.RegisterElement('browser-plugin', {prototype: proto});
delete proto.createdCallback;
delete proto.enteredDocumentCallback;
@@ -767,7 +764,8 @@ function registerWebViewElement() {
$Function.apply(internal.insertCSS_, internal, arguments);
};
- window.WebView = register.call(document, 'webview', {prototype: proto});
+ window.WebView =
+ DocumentNatives.RegisterElement('webview', {prototype: proto});
// Delete the callbacks so developers cannot call them and produce unexpected
// behavior.
« no previous file with comments | « chrome/renderer/extensions/document_custom_bindings.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698