Don't expose document.register to Chrome Apps by default.

chrome/renderer/extensions/document_custom_bindings.cc

Index: chrome/renderer/extensions/document_custom_bindings.cc
diff --git a/chrome/renderer/extensions/document_custom_bindings.cc b/chrome/renderer/extensions/document_custom_bindings.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f95cf342c562ef15616ff5a928010370b60d3cb9
--- /dev/null
+++ b/chrome/renderer/extensions/document_custom_bindings.cc
@@ -0,0 +1,62 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/extensions/document_custom_bindings.h"
+
+#include <string>
+
+#include "base/bind.h"
+#include "content/public/renderer/render_view.h"
+#include "third_party/WebKit/public/web/WebDocument.h"
+#include "third_party/WebKit/public/web/WebFrame.h"
+#include "third_party/WebKit/public/web/WebView.h"
+#include "v8/include/v8.h"
+
+namespace extensions {
+
+DocumentCustomBindings::DocumentCustomBindings(
+    Dispatcher* dispatcher, ChromeV8Context* context)
+    : ChromeV8Extension(dispatcher, context) {
+  RouteFunction("RegisterElement",
+      base::Bind(&DocumentCustomBindings::RegisterElement,
+                 base::Unretained(this)));
+}
+
+// Attach an event name to an object.
+void DocumentCustomBindings::RegisterElement(
+    const v8::FunctionCallbackInfo<v8::Value>& args) {
+  content::RenderView* render_view = GetRenderView();
+  if (!render_view) {
+    NOTREACHED();
+    return;
+  }
+
+  WebKit::WebView* web_view = render_view->GetWebView();
+  if (!web_view) {
+    NOTREACHED();

[Matt Perry, 2013/08/20 23:10:24]

I think both render_view and web_view can legitimately be NULL in some cases.
Don't NOTREACHED for them.

[Fady Samuel, 2013/08/21 11:47:24]

Done.

+    return;
+  }
+
+  WebKit::WebDocument document = web_view->mainFrame()->document();
+  if (args.Length() != 2) {
+    NOTREACHED();
+    return;
+  }
+
+  if (!args[0]->IsString() || !args[1]->IsObject()) {

[Matt Perry, 2013/08/20 23:10:24]

nit: combine this with the previous if

[Fady Samuel, 2013/08/21 11:47:24]

Done.

+    NOTREACHED();
+    return;
+  }
+
+  std::string element_name(*v8::String::AsciiValue(args[0]));
+  v8::Local<v8::Object> options = args[1]->ToObject();
+
+  WebKit::WebExceptionCode ec = 0;
+  v8::Handle<v8::Value> constructor =
+      document.registerEmbedderCustomElement(
+          WebKit::WebString::fromUTF8(element_name), options, ec);
+  args.GetReturnValue().Set(constructor);
+}
+
+}  // namespace extensions