Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4297)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java

Issue 2329153002: Remove the WARNING security level.
Patch Set: Restore top control test for sub.originalwebsite.com (but with ERROR instead of WARNING). Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java
index 8668eef13352b6e0dd87ad3559f58140e9ad237e..e5731895226867a8318a4983e7a5d34bfc777255 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java
@@ -191,24 +191,25 @@ public class OmniboxUrlEmphasizerTest extends NativeLibraryTestBase {
}
/**
- * Verify that a very short, warning HTTPS URL is colored correctly by
+ * Verify that a short, insecure HTTPS URL is colored correctly by
* OmniboxUrlEmphasizer.emphasizeUrl().
*/
@UiThreadTest
@MediumTest
@Feature({"Browser", "Main"})
- public void testVeryShortWarningHTTPSUrl() {
+ public void testShortWarningHTTPSUrl() {
Spannable url = new SpannableStringBuilder("https://www.dodgysite.com");
OmniboxUrlEmphasizer.emphasizeUrl(url, mResources, mProfile,
- ConnectionSecurityLevel.SECURITY_WARNING, false, true, true);
+ ConnectionSecurityLevel.SECURITY_ERROR, false, true, true);
EmphasizedUrlSpanHelper[] spans = EmphasizedUrlSpanHelper.getSpansForEmphasizedUrl(url);
- assertEquals("Unexpected number of spans:", 3, spans.length);
- spans[0].assertIsColoredSpan("https", 0, ApiCompatibilityUtils.getColor(mResources,
- R.color.url_emphasis_non_emphasized_text));
- spans[1].assertIsColoredSpan("://", 5, ApiCompatibilityUtils.getColor(mResources,
+ assertEquals("Unexpected number of spans:", 4, spans.length);
+ spans[0].assertIsStrikethroughSpan("https", 0);
+ spans[1].assertIsColoredSpan("https", 0, ApiCompatibilityUtils.getColor(mResources,
+ R.color.google_red_700));
+ spans[2].assertIsColoredSpan("://", 5, ApiCompatibilityUtils.getColor(mResources,
R.color.url_emphasis_non_emphasized_text));
- spans[2].assertIsColoredSpan(
+ spans[3].assertIsColoredSpan(
"www.dodgysite.com", 8, ApiCompatibilityUtils.getColor(mResources,
R.color.url_emphasis_domain_and_registry));
}

Powered by Google App Engine
This is Rietveld 408576698