Issue 2329143002: NOT FOR REVIEW. SAMPLE CODE ONLY.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2329143002: NOT FOR REVIEW. SAMPLE CODE ONLY. (Closed)

Created:
4 years, 3 months ago by skau

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, hashimoto+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

NOT FOR REVIEW. SAMPLE CODE ONLY. Smash together the debugd client with the settings UI. Printer will show up in print preview if you edit the name of an existing printer. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : rebase #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -37 lines)			Patch
M	chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js	View		3 chunks	+3 lines, -30 lines	0 comments	Download
M	chrome/browser/resources/settings/printing_page/cups_printer_details_page.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js	View		2 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc	View	1	3 chunks	+101 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 2232203003 Patch 160001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

skau

4 years, 3 months ago (2016-09-12 17:57:28 UTC) #1

Description was changed from

==========
NOT FOR REVIEW.  SAMPLE CODE ONLY.

Smash together the debugd client with the settings UI.  Printer will show up in
print preview if you edit the name of an existing printer.
==========

to

==========
NOT FOR REVIEW.  SAMPLE CODE ONLY.

Smash together the debugd client with the settings UI.  Printer will show up in
print preview if you edit the name of an existing printer.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages